-
Notifications
You must be signed in to change notification settings - Fork 46k
fix(backend): bound CountdownTimerBlock inputs and surface field-bound errors inline #13237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kcze
merged 7 commits into
dev
from
kpczerwinski/secrt-2319-fixblocks-cap-countdowntimerblock-duration-closes-5-ghsas
Jun 4, 2026
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
34de0f9
fix(blocks): validate CountdownTimerBlock duration bounds
kcze 68ebfaa
Merge remote-tracking branch 'origin/dev' into kpczerwinski/secrt-231…
kcze 580d2d6
docs: document CountdownTimerBlock duration and repeat bounds
kcze ab357fc
fix(blocks): address CountdownTimerBlock review feedback
kcze 393efcb
fix(blocks): tighten CountdownTimerBlock repeat bounds and harden run()
kcze 8126679
fix(backend): surface block input-bound violations as inline node errors
kcze 30ae327
fix(backend): address autogpt-pr-reviewer feedback on CountdownTimerB…
kcze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
autogpt_platform/backend/backend/blocks/time_blocks_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| from unittest.mock import AsyncMock | ||
|
|
||
| import pytest | ||
|
|
||
| from backend.blocks.time_blocks import CountdownTimerBlock | ||
|
|
||
|
|
||
| async def _run(block: CountdownTimerBlock, **input_kwargs): | ||
| outputs = [] | ||
| async for name, value in block.run(block.input_schema(**input_kwargs)): | ||
| outputs.append((name, value)) | ||
| return outputs | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_countdown_timer_rejects_excessive_duration(): | ||
| block = CountdownTimerBlock() | ||
| with pytest.raises(ValueError, match="exceeds max"): | ||
| await _run(block, days=365, repeat=1) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_countdown_timer_rejects_negative_duration(): | ||
| block = CountdownTimerBlock() | ||
| with pytest.raises(ValueError, match="non-negative"): | ||
| await _run(block, seconds="-1") | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_countdown_timer_allows_duration_at_cap(mocker): | ||
| sleep_mock = mocker.patch( | ||
| "backend.blocks.time_blocks.asyncio.sleep", new_callable=AsyncMock | ||
| ) | ||
| block = CountdownTimerBlock() | ||
| outputs = await _run(block, days=7, repeat=1) | ||
| assert outputs == [("output_message", "timer finished")] | ||
| sleep_mock.assert_awaited_once_with(7 * 86400) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.