-
Notifications
You must be signed in to change notification settings - Fork 46k
fix(backend/frontend): error handling, stream reconnection, and chat switching #12205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+528
−205
Merged
Changes from 13 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
08d5a2a
fix(backend): convert subtask limit from lifetime cap to concurrency …
majdyz db3d10f
fix(frontend): auto-reconnect copilot stream on disconnect
majdyz 142198d
fix(backend): release subtask slot on Task failure
majdyz 3c7545c
fix(backend): track subtask slots by tool_use_id
majdyz fea5e7d
Merge branch 'dev' into fix/copilot-subtask-concurrency-limit
majdyz cff210f
fix(frontend): reset refs on session switch, toast on reconnect failure
majdyz bfd98aa
Merge branch 'dev' into fix/copilot-subtask-concurrency-limit
majdyz ecc38f8
fix(backend): only consume subtask slot when tool_use_id is present
majdyz 5d06ef5
fix(backend): use proper typing instead of getattr in SDK logging
majdyz dba39cd
refactor(backend): simplify toolName access in SDK logging
majdyz 963eff0
Merge branch 'dev' into fix/copilot-subtask-concurrency-limit
majdyz c99b7aa
revert: keep defensive getattr for toolName logging
majdyz 82074fd
feat(backend/frontend): add stream diagnostics and stall detection
majdyz 2eb3641
fix(frontend): reconnect on network errors & increase SSE route timeout
majdyz ce58b12
fix(backend/frontend): stream reconnect, stall detection, dedup, thin…
majdyz 84334a0
fix(frontend): prevent duplicates on reconnect, remove unused var
majdyz d6760a4
fix(frontend): clear stall timer on session switch (sentry review)
majdyz c88d360
fix(backend): improve error handling and persistence in copilot
majdyz 9cea623
fix(backend): handle SDK cleanup RuntimeError during cancellation
majdyz 4fe8954
fix(platform): improve copilot error handling and stream reliability
majdyz 3ee6938
refactor(backend): consolidate exception handling, remove duplicate m…
majdyz 3bbd5ee
fix(backend): RuntimeError handling in SDK service
majdyz 670e557
fix(backend): use actual error message in StreamError
majdyz a66311a
fix(frontend): keep messages visible during reconnect
majdyz a56374a
fix(frontend): refetch session on tab focus, defer message clearing
majdyz 73ea149
fix(frontend): refetch session when switching between chats
majdyz 0a76a04
fix(backend): make exception handling order consistent
majdyz 4dd0b36
fix(frontend): clear hasResumed flag when switching chats
majdyz 2f42961
refactor: remove diagnostic logging (STREAM_DIAG)
majdyz 52caa84
fix(backend): persist error for RuntimeError cancel scope issue
majdyz 8f3eaa1
refactor(backend): simplify cancel scope RuntimeError handling
majdyz 70a8c2a
fix(backend): persist session messages when execution is stopped
majdyz 1f0442b
fix(backend): catch BaseException to handle CancelledError properly
majdyz adeb089
fix(backend/frontend): address PR review comments
majdyz d4b3c6c
refactor(backend): consolidate session completion logic
majdyz 5855a87
fix(backend): use new event loop in on_run_done callback
majdyz d613c4c
refactor(backend): move mark_session_completed to finally block
majdyz 4c376fb
refactor(backend): use temporary loop in finally block
majdyz 460f793
refactor(backend): move mark_session_completed to processor finally
majdyz 69254df
fix(backend): restore info log level for session persistence
majdyz 79a0cc0
fix(backend): preserve error message in session completion
majdyz a94b0ab
refactor(frontend): simplify reconnect logic and consolidate effects
majdyz 50c0b0c
fix(backend): prevent duplicate assistant message on reconnect
majdyz 213de50
Revert "fix(backend): prevent duplicate assistant message on reconnect"
majdyz 394cac5
fix(frontend): prevent duplicate messages on reconnect
majdyz ec0511d
fix(frontend): improve message deduplication on reconnect
majdyz 3eecd6b
refactor(frontend): simplify reconnect and deduplication logic
majdyz 3b30234
fix(frontend): deduplicate first assistant message across sources
majdyz de693f0
debug(frontend): add logging to investigate duplicate messages
majdyz 286f8c6
Revert "debug(frontend): add logging to investigate duplicate messages"
majdyz 205274a
refactor(frontend): remove ineffective content-based deduplication
majdyz 792674a
fix(frontend): reset prevStatusRef on session switch
majdyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.