docs(guidelines): document the component-level JSDoc block - #385
Open
H4ad wants to merge 1 commit into
Open
Conversation
H4ad
force-pushed
the
feat/component-guidelines-jsdoc
branch
from
September 7, 2026 21:02
b5bb669 to
1318b1a
Compare
H4ad
force-pushed
the
feat/component-guidelines-jsdoc
branch
from
September 7, 2026 21:16
1318b1a to
64dc5ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How to verify
Component checklist (required for any change under
packages/ui/src/)Philosophy (guidelines)
Structure (guidelines)
packages/ui/src/, matches the export subpathindex.tsonly re-exports (+ generated token region);export type *plus explicit named exports.jsextension; types imported withimport typesubcomponents/, opinionated compositions inpresets/src/index.ts,vite.config.ts,package.jsonexports,README.md+intro.mdxexternalPatternsCSS (guidelines)
{name}.module.scss, no Tailwind, no CVA, no Sass variablesvar(--{component}-x, <design token>); no hardcoded valuesvar(--spacing-4, 8px)); a bare literal only where no token matches--bg-*/--text-*primitives referenced from a component--{component}-internal-*--x: var(--x)and no duplicated variable definitionsdata-*attributes;data-slotanddata-testidon the rootcolor-mix()for derived shades, neverrgba()over a token:hover,:focus-visible,aria-invalid, disabled all styled@media (prefers-reduced-motion: reduce)pnpm run tokensrun and theindex.tsregion committedVisual QA (guidelines)
parameters.designsmmatchesButton/Input)Typographyor the type-scale tokens, not an ad-hocfont-size/font-weight@signozhq/icons, sized with tokens, no inline SVG with hardcodedpxTypes (guidelines)
{Component}Propsexported; only the props the component actually needs are exposedOriginalProps['x']), never restated by handindex.tsforwardRefwith a named render function (ordisplayName);testIdsupportedDocs (guidelines)
@defaultwhere applicable@access privateones exempt), correcttitlegroupargTypescomplete withcategory,type.summary,defaultValue.summary{component}.mdxwith a usage snippet and a<Controls>per exported pieceTests (guidelines)
forward-reftestrun-visual-testinglabel added if the change is visual