-
Notifications
You must be signed in to change notification settings - Fork 11
feat(button): rework component on top of @base-ui/react #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { Meta, Controls, Primary, Stories } from '@storybook/addon-docs/blocks'; | ||
| import * as ButtonGroupStories from './button-group.stories'; | ||
|
|
||
| <Meta of={ButtonGroupStories} /> | ||
|
|
||
| # ButtonGroup | ||
|
|
||
| A segmented cluster of related buttons. It renders `<div role="group">` with deduped internal | ||
| borders and only the outer corners rounded. | ||
|
|
||
| ## How to use | ||
|
|
||
| The group lays its children out in a row and squares off the borders between them. Each button | ||
| carries its own `variant`, `color` and `size`, and the group takes a `variant` and a `color` of | ||
| its own: | ||
|
|
||
| ```tsx | ||
| import { Button, ButtonGroup } from '@signozhq/ui'; | ||
|
|
||
| export default function MyComponent() { | ||
| return ( | ||
| <ButtonGroup variant="outlined" color="secondary" size="md"> | ||
| <Button variant="outlined" color="secondary" size="md"> | ||
| Day | ||
| </Button> | ||
| <Button variant="outlined" color="secondary" size="md"> | ||
| Week | ||
| </Button> | ||
| <Button variant="outlined" color="secondary" size="md"> | ||
| Month | ||
| </Button> | ||
| </ButtonGroup> | ||
| ); | ||
| } | ||
| ``` | ||
|
|
||
| `variant`, `color` and `size` on the group are mirrored as `data-variant`, `data-color` and | ||
| `data-size`, ready for your own selectors and assertions. | ||
|
|
||
| <Primary /> | ||
|
|
||
| ## Mixed appearances | ||
|
|
||
| Each member reads its own appearance, so one can differ from the rest: | ||
|
|
||
| ```tsx | ||
| <ButtonGroup variant="outlined" color="secondary" size="md"> | ||
| <Button variant="outlined" color="secondary" size="md"> | ||
| Approve | ||
| </Button> | ||
| <Button variant="outlined" color="secondary" size="md"> | ||
| Hold | ||
| </Button> | ||
| <Button variant="solid" color="danger" size="md"> | ||
| Reject | ||
| </Button> | ||
| </ButtonGroup> | ||
| ``` | ||
|
|
||
| Icon-only members work the same way, each with its own `aria-label`: | ||
|
|
||
| ```tsx | ||
| import { ChevronLeft, ChevronRight } from '@signozhq/icons'; | ||
|
|
||
| <ButtonGroup variant="outlined" color="secondary" size="md"> | ||
| <Button variant="outlined" color="secondary" size="md" icon aria-label="Previous"> | ||
| <ChevronLeft /> | ||
| </Button> | ||
| <Button variant="outlined" color="secondary" size="md" icon aria-label="Next"> | ||
| <ChevronRight /> | ||
| </Button> | ||
| </ButtonGroup>; | ||
| ``` | ||
|
|
||
| ## Props | ||
|
|
||
| <Controls of={ButtonGroupStories.Default} /> | ||
|
|
||
| <Stories includePrimary={false} title="Examples" /> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rework this later entirely, for now, we can keep this basic doc, this will change a lot after the doc proposal/layout