Skip to content

Prevent invalid helptags execution for unsupported documentation files - #48

Closed
Shougo with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-denops-api-error
Closed

Shougo with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-denops-api-error

Conversation

Copilot AI commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

:helptags was invoked when the merged doc directory contained .jax files but no .txt help files, causing Neovim E151: No match errors.

  • Help detection: Restrict hasHelpFiles() to .txt, matching Neovim’s :helptags glob.
  • Regression coverage: Verify .jax files alone do not trigger helptags generation.
if (entry.name.endsWith(".txt")) {
  // Run :helptags only for files Neovim can process.
}

Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
@Shougo

Shougo commented Sep 20, 2026

Copy link
Copy Markdown
Owner

@copilot https://github.com/vim-jp/vimdoc-ja https://github.com/vim-skk/skkeleton のように .jax しかない場合があります。その場合もちゃんと helptags が実行できるようにしてください。この修正では困ります

Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>

Copilot AI commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

@copilot https://github.com/vim-jp/vimdoc-ja https://github.com/vim-skk/skkeleton のように .jax しかない場合があります。その場合もちゃんと helptags が実行できるように...

.jax の検出を復元し、.jax のみの場合も helptags を実行する回帰テストを更新しました。Commit: 37fcb1f

@Shougo

Shougo commented Sep 20, 2026

Copy link
Copy Markdown
Owner

It is Neovim bug. I close it.

@Shougo Shougo closed this Sep 20, 2026
@Shougo
Shougo deleted the copilot/fix-denops-api-error branch September 20, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants