Skip to content

WIP: Sort material interaction in track fit - #17

Open
mesmith75 wants to merge 2 commits into
mainfrom
materials
Open

mesmith75 wants to merge 2 commits into
mainfrom
materials

Conversation

@mesmith75

@mesmith75 mesmith75 commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Not for merge or review yet. Just prodding.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8c4201a7-f54b-4f8d-870c-6f848f6d5caf


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

❌ prek hooks failed

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check toml...............................................................Passed
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
clang-format.............................................................Failed
- hook id: clang-format
- files were modified by this hook
cpplint..................................................................Passed
codespell................................................................Failed
- hook id: codespell
- exit code: 65

  src/acts_geometry_provider.cpp:156: wallThickness ==> wall thickness
  src/acts_geometry_provider.cpp:162: wallThickness ==> wall thickness
gersemi..................................................................Passed
validate CITATION.cff....................................................Passed
reuse lint...............................................................Passed

hint: Some hooks made changes to the files.
If you are seeing this message in CI, reproduce locally with: `prek run --all-files`
To run prek as part of Git workflow, use `prek install` to set up Git shims.

All changes made by hooks:
diff --git a/src/acts_geometry_provider.cpp b/src/acts_geometry_provider.cpp
index aaf10d5..8140c12 100644
--- a/src/acts_geometry_provider.cpp
+++ b/src/acts_geometry_provider.cpp
@@ -165,8 +165,8 @@ Acts::MaterialSlab buildStationMaterialSlab(G4VPhysicalVolume* world_pv) {
 
     // Series combination for thin scatterers: 1/X0_eff = sum(t_i / X0_i).
     double const x0 = tTotal / (tMylar / mylar->GetRadlen() + tGas / gas->GetRadlen());
-    double const l0 = tTotal / (tMylar / mylar->GetNuclearInterLength() +
-                               tGas / gas->GetNuclearInterLength());
+    double const l0 =
+        tTotal / (tMylar / mylar->GetNuclearInterLength() + tGas / gas->GetNuclearInterLength());
 
     // See the function comment above — placeholders, inert while energyLoss
     // is off.
@@ -174,9 +174,9 @@ Acts::MaterialSlab buildStationMaterialSlab(G4VPhysicalVolume* world_pv) {
     constexpr float kPlaceholderZ = 7.f;
     constexpr float kPlaceholderMassRho = 1.f;
 
-    Acts::Material const material = Acts::Material::fromMassDensity(
-        static_cast<float>(x0), static_cast<float>(l0), kPlaceholderAr, kPlaceholderZ,
-        kPlaceholderMassRho);
+    Acts::Material const material =
+        Acts::Material::fromMassDensity(static_cast<float>(x0), static_cast<float>(l0),
+                                        kPlaceholderAr, kPlaceholderZ, kPlaceholderMassRho);
 
     return Acts::MaterialSlab(material, static_cast<float>(tTotal));
 }

@mesmith75 mesmith75 changed the title Sort material interaction in track fit WIP: Sort material interaction in track fit Sep 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant