Repository navigation
fix(verify:offline): delegate to test:offline — it had drifted stale, missing /pro proofs - #765
Merged
Merged
Conversation
… missing /pro proofs verify:offline is JUDGE-FACING — DEMO.md and DEMO-RUNBOOK.md tell a judge to run it as the 'zero-network fairness + correctness proofs' command. But it carried its own hand-maintained test list that had drifted stale, MISSING 9 tests vs the canonical cold gate — including the /pro fairness proofs (test:pro-fairness, test:pro-commit-conformance, test:play-verify-loop, test:pro-pnl), which are the CORE of the submission. A judge running verify:offline silently skipped them. Fix: verify:offline = the two actual fairness-proof runs + 'npm run test:offline'. This adds all 9 missing tests AND makes it drift-proof — it can never fall behind test:offline again (delegation, not a parallel list). Strict superset, no loss; still fully zero-network. Verified: prefix green (4/4 /pro commits genuine, chain honest), test:offline green this session, delegation confirmed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maxmoneycash
added a commit
that referenced
this pull request
Jun 24, 2026
…ffline (#773) verify:offline is the judge-facing zero-network proof command (DEMO.md). My #765 made it delegate to test:offline so it can't drift stale (it previously carried a hand-maintained list that silently dropped the /pro fairness proofs). But that fix is a single package.json line — exactly the kind a stale-base --admin merge silently reverts (cf. the #752 revert, where my doc-count wiring vanished the same way). The existing leaf-coverage assertion can't catch a verify:offline revert (it's not a test:* leaf), so this adds a direct guard: verify:offline must include 'npm run test:offline'. A revert to a parallel hand-list now fails the cold gate. Verified: both cold-gate-coverage tests pass (2/2). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify:offline is judge-facing — DEMO.md:14 and DEMO-RUNBOOK.md:67 tell a judge to run it as the 'zero-network fairness + correctness proofs' command. But it carried its own hand-maintained test list that had drifted stale, missing 9 tests vs the canonical cold gate — including the /pro fairness proofs (test:pro-fairness, test:pro-commit-conformance, test:play-verify-loop, test:pro-pnl), the core of the submission. A judge running verify:offline silently skipped them.
Fix:
verify:offline= the two actual fairness-proof runs +npm run test:offline. Adds all 9 missing tests AND makes it drift-proof (delegation, not a parallel list — it can never fall behind again). Strict superset, no loss, still fully zero-network.Verified: prefix green (4/4 /pro commits genuine, chain honest), test:offline green this session, delegation confirmed.
🤖 Generated with Claude Code