Skip to content

fix(verify:offline): delegate to test:offline — it had drifted stale, missing /pro proofs - #765

Merged
maxmoneycash merged 1 commit into
mainfrom
a7/verify-offline-complete
Jun 24, 2026
Merged

maxmoneycash merged 1 commit into
mainfrom
a7/verify-offline-complete

Conversation

@maxmoneycash

Copy link
Copy Markdown
Member

verify:offline is judge-facing — DEMO.md:14 and DEMO-RUNBOOK.md:67 tell a judge to run it as the 'zero-network fairness + correctness proofs' command. But it carried its own hand-maintained test list that had drifted stale, missing 9 tests vs the canonical cold gate — including the /pro fairness proofs (test:pro-fairness, test:pro-commit-conformance, test:play-verify-loop, test:pro-pnl), the core of the submission. A judge running verify:offline silently skipped them.

Fix: verify:offline = the two actual fairness-proof runs + npm run test:offline. Adds all 9 missing tests AND makes it drift-proof (delegation, not a parallel list — it can never fall behind again). Strict superset, no loss, still fully zero-network.

Verified: prefix green (4/4 /pro commits genuine, chain honest), test:offline green this session, delegation confirmed.

🤖 Generated with Claude Code

… missing /pro proofs

verify:offline is JUDGE-FACING — DEMO.md and DEMO-RUNBOOK.md tell a judge to run it
as the 'zero-network fairness + correctness proofs' command. But it carried its own
hand-maintained test list that had drifted stale, MISSING 9 tests vs the canonical
cold gate — including the /pro fairness proofs (test:pro-fairness,
test:pro-commit-conformance, test:play-verify-loop, test:pro-pnl), which are the
CORE of the submission. A judge running verify:offline silently skipped them.

Fix: verify:offline = the two actual fairness-proof runs + 'npm run test:offline'.
This adds all 9 missing tests AND makes it drift-proof — it can never fall behind
test:offline again (delegation, not a parallel list). Strict superset, no loss;
still fully zero-network. Verified: prefix green (4/4 /pro commits genuine, chain
honest), test:offline green this session, delegation confirmed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maxmoneycash
maxmoneycash merged commit f89792e into main Jun 24, 2026
1 of 2 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wick-markets Building Building Preview, Comment Jun 24, 2026 8:17pm

Request Review

maxmoneycash added a commit that referenced this pull request Jun 24, 2026
…ffline (#773)

verify:offline is the judge-facing zero-network proof command (DEMO.md). My #765
made it delegate to test:offline so it can't drift stale (it previously carried a
hand-maintained list that silently dropped the /pro fairness proofs). But that fix
is a single package.json line — exactly the kind a stale-base --admin merge
silently reverts (cf. the #752 revert, where my doc-count wiring vanished the same
way). The existing leaf-coverage assertion can't catch a verify:offline revert
(it's not a test:* leaf), so this adds a direct guard: verify:offline must include
'npm run test:offline'. A revert to a parallel hand-list now fails the cold gate.

Verified: both cold-gate-coverage tests pass (2/2).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 41545a4b Deployed Jun 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant