Support jiff - #3018
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 726b780342
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[cfg(feature = "with-chrono")] | ||
| break 'value Value::ChronoDateTime( | ||
| row.try_get::<Option<chrono::NaiveDateTime>, _>(c.ordinal()) | ||
| .expect("Failed to get timestamp"), | ||
| ); |
There was a problem hiding this comment.
SeaORM's default feature set already includes with-chrono, so many users will enable with-jiff on top of the defaults. In that configuration this proxy-row conversion still breaks out on the chrono/time branch first, which means from_query_result_to_proxy_row stores Value::Chrono*/Value::Time* instead of the new Value::Jiff*. ProxyRow::try_get and the new try_getable_jiff! impl only accept Value::Jiff*, so Jiff reads through the proxy feature start failing on Postgres (and the same ordering issue exists in the SQLite proxy path).
Useful? React with 馃憤聽/ 馃憥.
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32fed93277
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f11d8c58f4
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31a0824521
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with-jiff = [ | ||
| "jiff", | ||
| "jiff-sqlx", | ||
| "sea-query/with-jiff", | ||
| "sea-query-sqlx?/with-jiff", | ||
| ] |
There was a problem hiding this comment.
with-jiff away from Arrow conversions
When a project enables both with-jiff and with-arrow, Arrow round-trips for Jiff-backed models are still unsupported even though this feature set is now exposed. ActiveModel::from_arrow only retries chrono鈫抰ime conversions (src/entity/active_model.rs:563-586), and sea-orm-arrow/src/lib.rs:154-170,1272-1403 only produces/extracts chrono/time Value variants, never Value::Jiff*. As a result, entities with JiffDate/JiffTime/JiffDateTime/JiffTimestamp cannot be imported from or exported to Arrow batches.
Useful? React with 馃憤聽/ 馃憥.
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c54003d6f3
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 725398b5ee
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9c37a3a to
96663c8
Compare
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96663c8c39
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b9172e7da
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| impl_timestamp!( | ||
| JiffUnixTimestamp, | ||
| JiffTimestamp, | ||
| from_timestamp, | ||
| to_timestamp | ||
| ); |
There was a problem hiding this comment.
When the serde feature is enabled, models containing JiffUnixTimestamp or JiffUnixTimestampMillis still cannot derive Serialize or Deserialize, because these new wrappers never invoke impl_serde_with_i64!. The equivalent Chrono and Time wrappers do so immediately after each impl_timestamp! invocation; enabling Jiff's own serde support does not provide traits for these outer wrapper types.
Useful? React with 馃憤聽/ 馃憥.
2 participants
PR Info
Closes Support jiff聽#2896
Dpendencies:
New Features