fix(npm): dynamically read version from package.json in beacon.js wrapper - #945
Merged
Scottcjn merged 1 commit intoSep 22, 2026
Conversation
Closes Scottcjn#939 Dynamically load version from package.json instead of hardcoding 1.0.0 constant, and add regression unit test.
|
Welcome to beacon-skill! Thanks for your first pull request. Quick checklist:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) A maintainer will review your PR soon! |
jmatson36097-blip
deleted the
fix/issue-939-npm-version-read-package-json
branch
September 22, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #939
bin/beacon.jsto load the package version from../package.jsonrather than a stale hardcoded1.0.0constant.package.jsonis inaccessible.tests/test_npm_wrapper.pyasserting thatnode bin/beacon.js --versionmatchespackage.json.version.Verification
node bin/beacon.js --versionoutput:2.17.0.python3 -m unittest tests/test_npm_wrapper.py: passed cleanly.