Conversation
thelostone-mc
force-pushed
the
transient
branch
4 times, most recently
from
February 27, 2026 07:39
5ae8901 to
ea6c274
Compare
thelostone-mc
marked this pull request as ready for review
March 2, 2026 05:51
apbendi
added a commit
that referenced
this pull request
Jul 25, 2026
Main's lockfile pinned rustix 0.36.8, which uses rustc_* attributes the current nightly compiler rejects, breaking the build/test/lint CI jobs. Lockfile taken verbatim from the transient branch (PR #64), which already contains these bumps.
apbendi
added a commit
that referenced
this pull request
Jul 25, 2026
* chore: fix clippy lints failing CI on latest nightly The clippy CI job installs the latest nightly clippy on every run, and newer lint versions now flag existing code on main: a redundant else after process::exit, redundant borrows in format! args, and an if that can be collapsed into a match guard. The variable_names and src_names_internal fixes mirror the identical changes already made on the transient branch (PR #64) so it rebases cleanly. * chore: bump rustix and is-terminal so main builds on latest nightly Main's lockfile pinned rustix 0.36.8, which uses rustc_* attributes the current nightly compiler rejects, breaking the build/test/lint CI jobs. Lockfile taken verbatim from the transient branch (PR #64), which already contains these bumps.
The offset-stability of the transient keyword stripping depends on the replacement string having the same length as the keyword; enforce that at compile time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.