feat(crucible-code): add the mcp settings - #6304
Merged
madskristensen merged 1 commit intoSep 4, 2026
Merged
Conversation
crucible-code 0.36.0 reads a top-level `mcp` key holding the Model Context Protocol servers it may start, and the published schema here predates it. Regenerated from the release so the block validates, with the positive test exercising every server key and two negative tests covering the two ways a server record goes wrong: a misspelled setting and a record with no command to run. Claude-Session: https://claude.ai/code/session_01TtwJEdGWh13be72DxUqHZE
NjoyimPeguy
requested review from
hyperupcall and
madskristensen
as code owners
September 4, 2026 11:14
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crucible-code0.36.0 added a top-levelmcpkey that the published schemadoes not know about, so a configuration using it is reported as an unknown
property. This regenerates the schema from that release and adds the tests for
the new block.
mcp.serversmaps a server name to what it takes to start it:command(required),
args,directory,env,envFrom,handshakeSeconds,requestSeconds,shutdownSeconds,restartsandrequired.mcpblock exercising every one of those keys.misspelled setting (
restartforrestarts), and a record with nocommand.Checks
npm clean-install, then prettier over the four files, thennode ./cli.js check --schema-name=crucible-code-schema.json— passes.The check was confirmed able to fail before it was trusted: typing
restartsas a string in the positive test fails Ajv validation, and making either
negative test legal is reported as "supposed to fail". All three edits were
reverted and the check re-run green.
https://claude.ai/code/session_01TtwJEdGWh13be72DxUqHZE