Fix isTypeFunc assertion failure - #476
Open
hyraxbyerax wants to merge 1 commit into
Open
Conversation
Collaborator
|
This code comes from WebAssembly/wabt#2695 |
Contributor
Author
|
@zherczeg Thanks for pointing this out. I'll consider fixing this without modifying the third-party WABT code. |
hyraxbyerax
force-pushed
the
fix/462-component-type-func-assertion
branch
from
August 14, 2026 13:18
d21dc15 to
04ed373
Compare
Collaborator
|
I am not sure you can do that. These changes must be present in the other PR to prevent their removal after an update. |
Collaborator
|
As walrus relies on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fuzzing revealed that Canonical Lift could reference a non-function type through
type_index, causing theisTypeFunc()assertion to fail.This change validates that
type_indexreferences a function type before processing Canonical Lift.(Fixes #462)