Skip to content

Add AgentScript doctor and common-pitfall guidance - #46

Closed
elijahbenizzy wants to merge 2 commits into
SalesforceAIResearch:mainfrom
elijahbenizzy:codex/agentscript-common-pitfalls
Closed

elijahbenizzy wants to merge 2 commits into
SalesforceAIResearch:mainfrom
elijahbenizzy:codex/agentscript-common-pitfalls

Conversation

@elijahbenizzy

@elijahbenizzy elijahbenizzy commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add /agentforce-doctor to reconstruct intended use cases, report only actionable findings, apply minimal repairs, and compare the unchanged baseline with the candidate
  • add diagnostic coverage for instruction overrides, prompt text that impersonates control flow, routing, action contracts, outputs, state, lifecycle, transitions, side effects, architecture, capability honesty, and evaluation integrity
  • require large agents to use bounded repair batches with parser checks and affected/unaffected regression cases between batches
  • integrate the skill with plugin discovery, file-copy installation, routing, agent manifests, and user documentation
  • add public AgentScript guidance for misleading pipe-text indentation, fake step sequencing, ungated actions, turn-ending setters, stale state, and competing side-effect owners

Evaluation integrity

  • derive expected behavior from user requirements, approved specs, existing tests, and reachable behavior—in that order
  • label inferred use cases instead of silently turning them into requirements
  • run the same use cases and evaluator against exact baseline and candidate revisions
  • inspect action availability, invocation, outputs, state, transitions, and external effects—not only final response text
  • never treat simulated actions as evidence of a live side effect

Validation

  • PYENV_VERSION=agentscript python -m pytest -q — 116 passed
  • Agentforce Doctor skill validator — passed
  • git diff --check
  • independent forward tests against an intentionally flawed generic agent and a large isolated AgentScript agent; no source or organization-specific artifacts are included in this PR
  • pinned open-source AgentScript asset validation (same CI command as the merge gate)

@elijahbenizzy elijahbenizzy changed the title Document common AgentScript control-flow pitfalls Add AgentScript doctor and common-pitfall guidance Jul 30, 2026
@almandsky

Copy link
Copy Markdown
Contributor

Please create the PR to the internal repo.

@almandsky almandsky closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants