Skip to content

Add galaxy overlay selection and label zoom controls - #293

Draft
Guffawaffle wants to merge 33 commits into
STFC-Mod:devfrom
Guffawaffle:feature/galaxy-label-controls
Draft

Guffawaffle wants to merge 33 commits into
STFC-Mod:devfrom
Guffawaffle:feature/galaxy-label-controls

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds Settings → Mod Settings → Galaxy Labels. Players can combine galaxy overlays and choose label detail or zoom thresholds independently for major and minor systems. Changes apply live through the shared persistence writer; defaults retain native behavior.

Depends on corrected #282 and its settings/persistence foundations. Following #313, ZoomHooks owns supported fleet/galaxy installation independently of feature values and native settings availability. Galaxy and fleet labels share one LOD detour in zoom.cc. On Mac, validated galaxy dependencies remain usable without fleet-specific widget dependencies; a failed LOD attempt is never retried through that fallback. The eight-hook galaxy family remains unavailable after partial installation. No shortcut or HUD sibling feature is included.

Validation: Windows release build, existing settings and full config-save/persistence suites, compile-time galaxy policy checks and all example TOMLs pass. Three independent semantic lanes review the complete candidate. Static Windows 270 extents cover galaxy and shared zoom/fleet targets, including the small selection callback; fit does not prove live relocation. Earlier combined-build Mac ARM smoke is historical evidence. Exact-candidate game smoke and supported Mac native extent/execution remain open. CI starts on publication without waiting for results.

@Guffawaffle
Guffawaffle force-pushed the feature/galaxy-label-controls branch from 7d79171 to 5e8a97c Compare September 24, 2026 02:38
@Guffawaffle
Guffawaffle force-pushed the feature/galaxy-label-controls branch from 397bbe8 to e010bfd Compare September 28, 2026 00:00
@Guffawaffle

Guffawaffle commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Hook/feature alignment follow-up for #313

Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under [patches] and feature checks inside the installed hooks.

Bring forward the corrected native-settings and fleet-label installation from #282. Galaxy hook registration already uses [patches].zoomhooks rather than a galaxy feature flag; keep the shared LOD hook under one owner and preserve that compatibility switch. [graphics].galaxy_overlay_*, galaxy_label_major_*, and galaxy_label_minor_* should continue controlling behavior after installation. This is a sibling of #285/#297, not their parent; update it independently from corrected #282 without importing those siblings.

Settings cascade (verified from current branch ancestry): #279 → #280; #277 + #280 → #281 → #282; sibling branches from #282 are #285, #293 and #297. #285 additionally depends on #269; #297 additionally depends on #296. Correct the owning parent first, then carry the fix through every dependent branch while preserving each sibling's scope.

Implemented in 8c2ef0f. Corrected #282 is merged without shortcut/HUD sibling scope. ZoomHooks remains the independent switch and zoom.cc owns the shared LOD detour; Mac fallback now distinguishes absent dependencies from a failed first attempt. Current galaxy page docs match implementation. Exact Windows build, settings/full persistence, policy assertions, examples, static Windows fit and three semantic lanes passed. CI is queued; exact-artifact overlay/pooling and Mac qualification remain open.

…ml-editor

# Conflicts:
#	docs/config-save.md
…gs-navigation

# Conflicts:
#	example_community_patch_settings_en.toml
#	mods/src/config.h
#	mods/src/defaultconfig.h
#	mods/src/patches/patches.cc
…ngs-controls

# Conflicts:
#	docs/MOD_SETTINGS_NAVIGATION.md
#	mods/src/config.cc
#	mods/src/config.h
#	mods/src/patches/parts/forbidden_tech_confirmation.cc
#	mods/src/patches/parts/hotkeys.cc
#	mods/src/patches/patches.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant