Soft delete async correction - #13171
Open
BigMark824 wants to merge 6 commits into
Open
Conversation
BigMark824
requested review from
Lewkans,
isaaclombardssw,
lukecookssw,
tiagov8 and
tomek-i
August 13, 2026 02:14
github-actions
Bot
added
Age: 🥚 - New
github-actions
Bot
added
Age: 🐓 - Old
Contributor
|
Howzit @BigMark824, This PR has been here a while. Did you know you should avoid merge debt?
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ When working on my FireBootCamp project I tried to use the Interceptor from this rule using an async remove, unfortunately that lead to my column being hard deleted instead of checking off the
IsDeletedfield. I believe it would be better to explicitly talk about needing anSavingChangesAsyncsince it isn't immediately clear.Also the original name (Do you avoid deleting records by flagging them as IsDeleted) is too much of a tongue twister, I renamed it to be more of a positive sounding name than the original confusing one.
✏️
SoftDeleteInterceptornow has aSavingChangesAsyncmethod✏️ Title was changed from `Do you avoid deleting records by flagging them as IsDeleted (aka soft delete) to Do you know you can retain records by flagging them as IsDeleted (aka Soft Delete)?