Better curve thicken - #205
Open
VikingScientist wants to merge 2 commits into
Open
VikingScientist wants to merge 2 commits into
VikingScientist wants to merge 2 commits into
Conversation
VikingScientist
force-pushed
the
better_curve_thicken
branch
from
September 4, 2026 07:27
425d850 to
968466c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 74.02% 74.92% +0.90%
==========================================
Files 30 30
Lines 5066 5396 +330
Branches 844 904 +60
==========================================
+ Hits 3750 4043 +293
- Misses 1102 1117 +15
- Partials 214 236 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ports the suggested solution of the summer intern Casper work for fixing `surface_factory.thicken()` to deal with high-curvature regions where thicken will cause self-intersecting surfaces.
TheBB
force-pushed
the
better_curve_thicken
branch
from
September 4, 2026 07:36
968466c to
1deabfb
Compare
Member
|
Rebased on master. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement for high-curvature regions which causes the
surface_factory.thicken()to create self-intersecting surface.Blue is old method
Orange is the new method