Added function for arc length parameterization - #203
Merged
VikingScientist merged 1 commit intoJul 6, 2026
Merged
Conversation
Member
|
Too many commits. Squash them to a single one. Also: The end change to |
Aurora110104
force-pushed
the
add_arc_length_parameterization
branch
2 times, most recently
from
July 6, 2026 08:11
f875e2f to
88e78f1
Compare
Contributor
Author
|
Understood, I have squashed them now, and they should only change curve_factory.py and curve_factory_test.py. |
Changed input format Moved function Added -> Curve Added test function Moved function to curve_factory Moved test function Removed whitespaces and fixed some issues Added function for arc length parameterization#
Aurora110104
force-pushed
the
add_arc_length_parameterization
branch
from
July 6, 2026 08:38
88e78f1 to
23d0962
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 73.60% 74.02% +0.41%
==========================================
Files 30 30
Lines 4982 5066 +84
Branches 828 844 +16
==========================================
+ Hits 3667 3750 +83
+ Misses 1105 1102 -3
- Partials 210 214 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function to curve_factory.py that takes in a curve, and returns an arc length parameterized version of this curve, using uniformly spaced samples and least square fit. The function will add more knots to the curve if needed. Also added a test function for this function to curve_factory_test.py.