Skip to content

Added function for arc length parameterization - #203

Merged
VikingScientist merged 1 commit into
SINTEF:masterfrom
Aurora110104:add_arc_length_parameterization
Jul 6, 2026
Merged

VikingScientist merged 1 commit into
SINTEF:masterfrom
Aurora110104:add_arc_length_parameterization

Conversation

@Aurora110104

Copy link
Copy Markdown
Contributor

Added a function to curve_factory.py that takes in a curve, and returns an arc length parameterized version of this curve, using uniformly spaced samples and least square fit. The function will add more knots to the curve if needed. Also added a test function for this function to curve_factory_test.py.

@VikingScientist

Copy link
Copy Markdown
Member

Too many commits. Squash them to a single one.

Also: The end change to Curve.py and Curve_test.py is two empty line additions; leftover from placing new functionality in one place and moving it later. Better to not touch the files at all in the final commit.

@Aurora110104
Aurora110104 force-pushed the add_arc_length_parameterization branch 2 times, most recently from f875e2f to 88e78f1 Compare July 6, 2026 08:11
@Aurora110104

Copy link
Copy Markdown
Contributor Author

Understood, I have squashed them now, and they should only change curve_factory.py and curve_factory_test.py.

Changed input format

Moved function

Added -> Curve

Added test function

Moved function to curve_factory

Moved test function

Removed whitespaces and fixed some issues

Added function for arc length parameterization#
@Aurora110104
Aurora110104 force-pushed the add_arc_length_parameterization branch from 88e78f1 to 23d0962 Compare July 6, 2026 08:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.90476% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.02%. Comparing base (f3b9f3a) to head (23d0962).

Files with missing lines Patch % Lines
src/splipy/curve_factory.py 86.90% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   73.60%   74.02%   +0.41%     
==========================================
  Files          30       30              
  Lines        4982     5066      +84     
  Branches      828      844      +16     
==========================================
+ Hits         3667     3750      +83     
+ Misses       1105     1102       -3     
- Partials      210      214       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VikingScientist
VikingScientist merged commit c7a0852 into SINTEF:master Jul 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants