Skip to content

Add Ruby 4.0 and head to CI matrix - #131

Merged
yukideluxe merged 3 commits into
RubyMoney:mainfrom
wwahammy:patch-1
Mar 29, 2026
Merged

Add Ruby 4.0 and head to CI matrix#131
yukideluxe merged 3 commits into
RubyMoney:mainfrom
wwahammy:patch-1

Conversation

@wwahammy

Copy link
Copy Markdown
Contributor

No description provided.

sunny
sunny previously approved these changes Mar 29, 2026
@wwahammy

wwahammy commented Mar 29, 2026

Copy link
Copy Markdown
Contributor Author

@sunny I disabled fail-fast on the matrix so we can actually see if the workflow failure is ruby version specific or not.

@wwahammy
wwahammy requested a review from sunny March 29, 2026 16:10
@yukideluxe

yukideluxe commented Mar 29, 2026

Copy link
Copy Markdown
Member

@wwahammy can you rebase with main? I did not realize I was not in a branch and I pushed the fix Claude did to main (@sunny I AM SORRY, maybe we need to protect that branch 😬). The fix is pretty straightforward, the tests were doing live requests to https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml because it was not properly stubbed and it seems the response has changed 😳

b41d913

@sunny sunny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging main added the spec fix that @yukideluxe pushed, LGTM!

@yukideluxe
yukideluxe merged commit a60676f into RubyMoney:main Mar 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants