Skip to content

v2.0.0 馃帀 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunny merged 7 commits into from
Dec 10, 2025
Merged

v2.0.0 馃帀 #129

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
148596d
v2.0.0 馃帀
sunny Dec 9, 2025
08f7ff0
Use VERSION
sunny Dec 9, 2025
d39a624
Add money dependency
sunny Dec 9, 2025
aa0ed67
Use static version
sunny Dec 9, 2025
5025dcc
Minor comment update
sunny Dec 9, 2025
94df9f2
Update CHANGELOG for version
sunny Dec 9, 2025
f5ff3da
Spec for version
sunny Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## Upcoming release (unreleased)

## 2.0.0 (Dec 9 2025)

* **Breaking change**: Require Ruby >= 3.1
* **Breaking change**: Update Money dependency to 7.0. Make sure to read [the upgrade
guide](https://github.com/RubyMoney/money/blob/main/UPGRADING-7.0.md).
* Update YAML loading from compatibility with recent Psych versions.
* Move Croatian Kuna (HRK) and Russian Ruble (RUB) to legacy currencies

Expand Down
12 changes: 9 additions & 3 deletions eu_central_bank.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
#!/bin/env ruby
# encoding: utf-8
# frozen_string_literal: true

lib = File.expand_path("lib", __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

require "eu_central_bank/version"

Gem::Specification.new do |s|
s.name = "eu_central_bank"
s.version = "1.7.0"
s.version = EuCentralBank::VERSION
s.platform = Gem::Platform::RUBY
s.authors = ["Shane Emmons"]
s.email = ["shane@emmons.io"]
Expand All @@ -19,7 +25,7 @@ Gem::Specification.new do |s|

s.add_dependency "bigdecimal"
s.add_dependency "nokogiri", "~> 1.11"
s.add_dependency "money", "~> 6.19"
s.add_dependency "money", "~> 7.0"

s.add_development_dependency "rspec", "~> 3.13"

Expand Down
5 changes: 5 additions & 0 deletions lib/eu_central_bank/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# frozen_string_literal: true

class EuCentralBank < Money::Bank::VariableExchange

@yukideluxe yukideluxe Dec 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, the test failure is legit. It should not inherit from Money::Bank::VariableExchange 馃槉

@sunny sunny Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we have to use the same inheritance as in lib/eu_central_bank.rb or we鈥檇 risk a superclass mismatch for class EuCentralBank (TypeError) when loading the version after the class. 馃珷

I鈥檝e opted to add a comment instead.

@yukideluxe yukideluxe Dec 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

VERSION = "2.0.0"
end
Loading