-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: migrating touch component to RN touchable from RNGH #7473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Rohit3523
wants to merge
43
commits into
develop
Choose a base branch
from
ui-kit-button-fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
109e596
Changes
Rohit3523 946e086
temp solution
Rohit3523 b0703d5
moving to RN Touchable
Rohit3523 442eee9
test fix
Rohit3523 2334cbd
add hidekeyboard
Rohit3523 73e8bcc
lint fix
Rohit3523 6bc22e0
temporary let me build android apk to test
Rohit3523 a04b802
using correct gate this time
Rohit3523 5ecd71c
small test for 2FA Modal
Rohit3523 9a7d4e5
Merge branch 'develop' into ui-kit-button-fix
Rohit3523 c66940f
restore touch file
Rohit3523 8c09e6d
chore: format code and fix lint issues
Rohit3523 24bc31f
Import fix and remove one touch
Rohit3523 6ce41b8
Merge branch 'ui-kit-button-fix' of https://github.com/RocketChat/Roc…
Rohit3523 3998556
trying pressable from RNGH on android
Rohit3523 1044076
temporary disabled longPress test and link
Rohit3523 e134ee4
test import fix
Rohit3523 c1bc640
recover build-pr
Rohit3523 6a7bed4
some improvements
Rohit3523 2b0e87d
Merge branch 'develop' into ui-kit-button-fix
Rohit3523 dbff978
readded link long press test
Rohit3523 0fad987
Merge branch 'develop' into ui-kit-button-fix
Rohit3523 2e14ff6
updated test-map to include 2fa test
Rohit3523 b54a03e
added no memo annotation in actions component
Rohit3523 efa656d
ios server history background color fix
Rohit3523 6551848
added hasInlineTextPressClaim
Rohit3523 99751ee
rename inlineTextPress to nestedPress
Rohit3523 8944f23
using it as hook
Rohit3523 98141fd
move testId to child view
Rohit3523 b38a136
Merge branch 'develop' into ui-kit-button-fix
Rohit3523 f644fb4
added timeout for room scroll
Rohit3523 8131b23
snapshot update
Rohit3523 c3ee622
fix swipeable
Rohit3523 b97149c
revert the testId change
Rohit3523 ae4d8a4
improve unread-badge test to wait till alert remove before pressing back
Rohit3523 cea4e01
snap update
Rohit3523 2aaacfe
keyboard nav fix
Rohit3523 adcdb7e
Merge branch 'develop' into ui-kit-button-fix
Rohit3523 e000cb1
snapshot update
Rohit3523 c6ab438
snap update
Rohit3523 913284c
using test id for convert to channel
Rohit3523 4adca68
disable touch accessible for e2e test
Rohit3523 6d8f981
added test id for convert to channel
Rohit3523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| appId: ${APP_ID} | ||
| name: Two Factor Modal Test | ||
| onFlowStart: | ||
| - runFlow: ../../../helpers/setup.yaml | ||
| tags: | ||
| - test-2 | ||
|
|
||
| --- | ||
| - runFlow: ../../../helpers/launch-app.yaml | ||
| - runFlow: ../../../helpers/navigate-to-login.yaml | ||
| - tapOn: | ||
| id: 'login-view-email' | ||
| - inputText: 'mobile+e2e_2fa_modal_test@rocket.chat' | ||
| - pressKey: enter | ||
| - tapOn: | ||
| id: 'login-view-password' | ||
| - inputText: 'e2e_2fa_modal_test' | ||
| - runFlow: '../../../helpers/hide-keyboard.yaml' | ||
| - tapOn: | ||
| id: login-view-submit | ||
|
|
||
| # Verify that 2FA modal is visible | ||
| - extendedWaitUntil: | ||
| visible: '.*Open your authentication app and enter the code.*' | ||
| timeout: 5000 | ||
| - assertVisible: 'Cancel' | ||
| - assertVisible: 'Verify' | ||
|
|
||
| # Click verify button with wrong TOTP to make sure it's clickable and working | ||
| - tapOn: | ||
| id: 'two-factor-input' | ||
| - inputText: '000000' | ||
| - tapOn: 'Verify' | ||
| - extendedWaitUntil: | ||
| visible: '.*Invalid code.*' | ||
| timeout: 5000 | ||
|
|
||
| # Click cancel button and it should hide 2FA modal | ||
| - tapOn: 'Cancel' | ||
| - extendedWaitUntil: | ||
| visible: '.*Your credentials were rejected! Please try again.*' | ||
| timeout: 5000 | ||
| - tapOn: 'OK' | ||
| - extendedWaitUntil: | ||
| notVisible: '.*Your credentials were rejected! Please try again.*' | ||
| timeout: 5000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Incorrect contains-pattern for text selectors.
These text selectors use
'.*keyword*.'instead of the correct'.*keyword.*'form (leading and trailing.*). Since the target keyword sits at the end of the matched string in all three cases, the pattern will fail to match at runtime.Based on learnings, in Maestro YAML selector fields, use the contains pattern
'.*keyword.*'(leading and trailing.*);'.*keyword*.'is incorrect and will fail to match cases where the keyword appears at the end of the element's text.🩹 Proposed fix
Also applies to: 267-267, 286-286
🤖 Prompt for AI Agents
Source: Learnings