Use StructArmed on QA - #1580
Open
samsonasik wants to merge 8 commits into
Open
Conversation
Author
|
@Ocramius ready for review/merge 👍 |
samsonasik
force-pushed
the
use-structarmed-qa
branch
from
September 10, 2026 02:51
9a525d9 to
1194767
Compare
Author
|
Rebased 👍 |
Member
|
Hey @samsonasik, just FYI, I didn't ignore your patches about this (and on other repositories as well), but I simply didn't get to play around with the tool yet. @kukulich @asgrim do you have opinions on a layer structure we could follow for this project, BTW? |
samsonasik
commented
Sep 10, 2026
Author
|
@Ocramius that's fine, if ruleset layering need in separate PR and just need apply PSR4 for starter, just let me know ;) |
Collaborator
|
I'm not against new check tool however the configuration looks too complicated to me: https://github.com/Roave/BetterReflection/pull/1580/changes#diff-6c750795fe8e9ac3fc3936402fef25d2ca69ca1d01ef0f16c2ad8b27cde4b041 |
samsonasik
force-pushed
the
use-structarmed-qa
branch
from
September 12, 2026 10:28
bf3c4f8 to
09704bd
Compare
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
StructArmedto QA:https://github.com/boundwize/structarmed
It is a configurable PHP architecture guards with built in presets (psr4, mvc, and so on). This PR apply
StructArmedwith register:PSR4 Preset
This PR start apply StructArmed with initialize using PSR4 preset, and already help fix 8 violations.
I also enable ruleset so it show more ability of layering setup to define which layers each layer is allowed to depend on.
Register to Github workflow.