Skip to content

Fix Reddit video posts using preview URLs - #2199

Open
Rahul-Jena-2002 wants to merge 1 commit into
RipMeApp:mainfrom
Rahul-Jena-2002:fix/reddit-video-preview-2197
Open

Rahul-Jena-2002 wants to merge 1 commit into
RipMeApp:mainfrom
Rahul-Jena-2002:fix/reddit-video-preview-2197

Conversation

@Rahul-Jena-2002

Copy link
Copy Markdown

Category

Description

Reddit video posts can point url to a still-image preview even when Reddit provides the actual video URL in secure_media.reddit_video.fallback_url. For posts marked is_video, this change prefers the video URL when available and keeps the existing URL behavior otherwise.

Closes #2197.

Testing

Required verification:

  • I've verified that there are no regressions in gradlew test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

The two focused Reddit regression tests passed. The full test suite and live downloading behavior were not verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Ripping still image instead of full video (reddit/imgur)

1 participant