Repository navigation
Fix LusciousRipper URL handling and image extraction - #2196
Open
Rohan010101 wants to merge 1 commit into
Open
Rohan010101 wants to merge 1 commit into
Rohan010101 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2168.
Update
LusciousRipperto work with the current Luscious URL structure and provide an HTML-based fallback for image extraction when the existing GraphQL API is unavailable.Changes
URL handling
Updated the Luscious album URL pattern to support:
luscious.netwww.luscious.netmembers.luscious.netlegacy.luscious.netRemoved support for the obsolete
old.luscious.nethost.Updated URL sanitization so it no longer rewrites URLs to
old.luscious.net.Verified that album IDs continue to be extracted correctly.
Image extraction
The existing implementation retrieves image URLs through the Luscious GraphQL endpoint at
apicdn.luscious.net.During investigation, the endpoint was found to no longer be resolvable, causing the existing API-based extraction to fail.
Inspection of accessible Luscious album HTML showed that image URLs are directly present in
<img src>elements and are served fromah-img.luscious.net.The ripper now:
This preserves the existing API implementation while providing an alternative extraction method.
Testing
git diff --checkpasses with no whitespace errors.Known limitation
Some Luscious content appears to depend on an authenticated browser/session context. Such content may remain inaccessible to RipMe when the required session state is unavailable.
Cookie/session handling was not addressed as part of this change and is considered a separate issue.