Repository navigation
Kemono ripper and danbooru fix - #2160
Conversation
…o.cr Adapted from PR RipMeApp#2160 (66b3469d, "Adding KemonoPartyRipper"), rebased from that PR's stale base (predates the DownloadFileThread/AbstractRipper thread-pool rewrite) onto today's main, where it needed no API changes - addURLToDownload(url, prefix) and the AbstractJSONRipper template method contract are unchanged. kemono.su and kemono.party no longer resolve (confirmed via DNS lookup and web search, 2026-08-15); kemono.cr is the domain the project's own status channel currently points at. Repointed the API and CDN (c1/c3) base URLs there and dropped the unused current_page_data field. canRip() still accepts all three hostnames so existing links/history keep working. Not included from RipMeApp#2160: - The DanbooruRipper "fix": verified live that danbooru.donmai.us's posts.json already returns file_url for accessible posts (19/20 in a sample query); the one post missing it was pending/restricted and remained without a file_url even via the PR's proposed per-post fetch workaround. That change would have added an HTTP request per post for every rip without fixing the gap it targeted, so it's left out. - The App.java/AbstractRipper.java/DownloadFileThread.java/History.java/ MainWindow.java/FileFinishCallBack.java changes: an OkHttp rewrite of DownloadFileThread from a stale base, now fully superseded by main's own thread-pool/race-condition rework, plus dead code (unused FileFinishCallBack, a broken unused import, a commented-out history-rewrite block) not needed by either ripper. - test.json/test2.json (accidentally committed fixtures) and the FreeComicOnlineRipperTest change (that test is already tagged flaky and pointed at a working URL on main, via a separate fix). Caveat: kemono.cr itself is reachable by DNS but refused connections during this review (the service's own status channel reports it mid-maintenance), so this could not be exercised against a live response - only checked for compiling against the current AbstractJSONRipper contract. Co-authored-by: Undid Iridium <FrancisXIrizarry@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018v7wmgDn3VKQRo8hbFCR6S
042c6a0 to
ab70176
Compare
|
Reviewed and rewrote the branch (with maintainer-edit access) down to just the piece that still holds up: Kept — Dropped — the Danbooru change Dropped — everything else in the diff Thanks for the original Kemono ripper and Danbooru investigation — kept your authorship on the surviving commit. Merging once CI is green. |
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Testing
Required verification:
gradlew test(there are no new failures or errors) (As far as I can tell).(I would argue it should have the name of the artist then ID but..)
Optional but recommended: