Remove use of brace expansion, which isn't defined in POSIX

[darkrain42]

This breaks when vcsh's shell is /bin/sh (as in vcsh-standalone.sh) and /bin/sh is dash (as is default in Debian and Ubuntu).

root@be86826c025e:~# ./vcsh-standalone.sh write-gitignore demo
vcsh-standalone.sh: info: '/root/.gitignore.d/demo' differs from new data, moving it to '/root/.gitignore.d/demo.bak'
mv: missing destination file operand after '/root/.gitignore.d/demo{,.bak}'
Try 'mv --help' for more information.
vcsh-standalone.sh: fatal: could not move '/root/.gitignore.d/demo' to '/root/.gitignore.d/demo.bak'
root@be86826c025e:~#

[alerque]

Thank you for this fix. I've tested in dash and others, but clearly not all the code paths have gotten exercised. We're definitely targeting as limited a POSIX shell environment as we can for maximum portability.

[alerque]

Do we need a patch release put out for this? Are you working on Debian packaging or anything like that?

I'd like to get #349 addressed before another release but ran into some funny cart-horse scenario in the latest GNU Autotools release that I haven't had time to ferret out.

[darkrain42]

Do we need a patch release put out for this? Are you working on Debian packaging or anything like that?

I don't think it's urgent; this has been broken for quite a while (introduced in aeae010).

The Debian-packaged version of vcsh has a shebang of #!/bin/bash, so isn't affected by this problem -- it's unique(?) to the standalone version.