feat(Checkpoints): consume canonical audience configuration - #7543
Open
rickvdl wants to merge 13 commits into
Open
feat(Checkpoints): consume canonical audience configuration#7543rickvdl wants to merge 13 commits into
rickvdl wants to merge 13 commits into
Conversation
|
rickvdl
force-pushed
the
rickvdl/canonical-audience-config
branch
from
August 28, 2026 13:28
54c6fc2 to
3190ab1
Compare
rickvdl
commented
Aug 28, 2026
Member
Author
|
@RCGitBot please test |
rickvdl
commented
Aug 31, 2026
tonidero
approved these changes
Sep 1, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
This makes sense! Just some non-blocker comments
Base automatically changed from
rickvdl/checkpoints-web-checkout-outcome
to
main
September 1, 2026 14:29
rickvdl
force-pushed
the
rickvdl/canonical-audience-config
branch
from
September 1, 2026 14:31
02f5906 to
688af77
Compare
ajpallares
reviewed
Sep 1, 2026
ajpallares
reviewed
Sep 2, 2026
ajpallares
left a comment
Member
There was a problem hiding this comment.
I added some more comments!
rickvdl
force-pushed
the
rickvdl/canonical-audience-config
branch
from
September 2, 2026 11:58
688af77 to
0271dc8
Compare
Member
Author
|
@RCGitBot please test |
Member
Author
|
@RCGitBot please test |
Member
Author
|
@RCGitBot please test |
rickvdl
marked this pull request as ready for review
September 4, 2026 11:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR we're now reading one static blob with all audience rules from the remote config infrastructure, as well as an object of
backend_predicate_results, which contains the backend computed facts that we should fill in at the placeholders in the rules of the audiences blobs.Changes
This PR contains the following:
backend_predicate_resultsobject from the audiences topic. This object is kept in memory for easy access.bool's for now, but any value that works in the rules evaluator (DimensionValue) should work here, for future extensibility.backend_predicate_resultsare passed into the rules evaluator through thebackendValues. Ensuring that these values are used in rules (through thebackend.*dimension) where these variables are mentionedRelated Android PR
Note
Medium Risk
Changes checkpoint targeting, remote-config key handling, and audience loading paths; mis-decoding or generation mismatches could cause incorrect matches or spurious configuration-unavailable outcomes.
Overview
Checkpoint resolution now loads one generation-bound audience snapshot (rules from the
defaultblob plus inlinebackend_predicate_results) instead of looking up audiences live, and passes subscriber-specific facts into rule evaluation asbackend.*dimensions alongsidecustom.*.Checkpoint workflow resolver retries resolution once when checkpoint or audience config goes stale mid-flight, keeps checkpoint rules and audience data on the same config generation, and feeds
backendPredicateResultsinto the local rules matcher so audience predicates can reference hashed backend placeholders.Remote config decoding preserves exact wire keys in
ConfigItem.content(including opaque condition hashes and snake_case fields likeoffering_identifier), which workflows and audience metadata rely on. AudiencesConfigProvider decodes the canonical audience map from the prefetched blob, tolerates per-audience decode failures, and converts supportedAnyDecodablevalues toDimensionValuefor rules.Tests cover retry/stale behavior, backend predicate matching (booleans and other dimension types), and the new audiences topic shape.
Reviewed by Cursor Bugbot for commit c62b9aa. Bugbot is set up for automated code reviews on this repo. Configure here.