Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion baselineprofile/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

plugins {
alias(libs.plugins.android.test)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.baselineprofile)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.revenuecat.purchases.android.buildlogic.convention

import com.android.build.gradle.BaseExtension
import com.android.build.api.dsl.ApplicationExtension
import com.revenuecat.purchases.android.buildlogic.ktx.getVersion
import com.revenuecat.purchases.android.buildlogic.ktx.versionCatalog
import org.gradle.api.JavaVersion
Expand All @@ -14,8 +14,8 @@ internal fun Project.configureAndroidApplication() {
val minSdkVersion = libs.getVersion("android-minSdk").toInt()
val targetSdkVersion = libs.getVersion("android-targetSdk").toInt()

extensions.configure<BaseExtension> {
compileSdkVersion(compileSdkVersion)
extensions.configure<ApplicationExtension> {
compileSdk = compileSdkVersion

defaultConfig {
minSdk = minSdkVersion
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.revenuecat.purchases.android.buildlogic.convention

import com.android.build.api.dsl.LibraryExtension
import com.android.build.api.variant.HasUnitTestBuilder
import com.android.build.api.variant.LibraryAndroidComponentsExtension
import com.android.build.gradle.LibraryExtension
import com.revenuecat.purchases.android.buildlogic.ktx.getVersion
import com.revenuecat.purchases.android.buildlogic.ktx.versionCatalog
import org.gradle.api.JavaVersion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ internal val VersionCatalog.plugins: PluginAccessor

internal class PluginAccessor(private val catalog: VersionCatalog) {
val android: PluginGroup get() = PluginGroup(catalog, "android")
val kotlin: PluginGroup get() = PluginGroup(catalog, "kotlin")
val kover: Provider<PluginDependency> get() = catalog.findPlugin("kover").get()
val dokka: Provider<PluginDependency> get() = catalog.findPlugin("dokka").get()
val mavenPublish: Provider<PluginDependency> get() = catalog.findPlugin("mavenPublish").get()
Expand All @@ -37,5 +36,4 @@ internal class PluginAccessor(private val catalog: VersionCatalog) {
internal class PluginGroup(private val catalog: VersionCatalog, private val prefix: String) {
val library: Provider<PluginDependency> get() = catalog.findPlugin("$prefix.library").get()
val application: Provider<PluginDependency> get() = catalog.findPlugin("$prefix.application").get()
val android: Provider<PluginDependency> get() = catalog.findPlugin("$prefix.android").get()
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
override fun apply(target: Project) = with(target) {
with(pluginManager) {
apply(libs.plugins.android.application.get().pluginId)
apply(libs.plugins.kotlin.android.get().pluginId)
}
configureAndroidApplication()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ class ApiTesterApplicationConventionPlugin : Plugin<Project> {
override fun apply(target: Project) = with(target) {
with(pluginManager) {
apply(libs.plugins.android.application.get().pluginId)
apply(libs.plugins.kotlin.android.get().pluginId)
}

configureAndroidApplication()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class PublicLibraryConventionPlugin : Plugin<Project> {
override fun apply(target: Project) = with(target) {
with(pluginManager) {
apply(libs.plugins.android.library.get().pluginId)
apply(libs.plugins.kotlin.android.get().pluginId)
apply(libs.plugins.kover.get().pluginId)
apply(libs.plugins.baselineprofile.get().pluginId)
}
Expand Down
1 change: 0 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ plugins {
alias(libs.plugins.android.application) apply false
alias(libs.plugins.android.library) apply false
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.kotlin.android) apply false
alias(libs.plugins.kotlin.jvm) apply false
alias(libs.plugins.kover) apply false
alias(libs.plugins.emerge) apply false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import java.util.Properties

plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose.compiler)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
alias(libs.plugins.android.application).apply(false)
alias(libs.plugins.kotlin.android).apply(false)
alias(libs.plugins.compose.compiler).apply(false)
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,3 @@ kotlin.code.style=official
# resources declared in the library itself and none from the library's dependencies,
# thereby reducing the size of the R class for that library
android.nonTransitiveRClass=true

# Built-in Kotlin rejects the kotlin-android plugin, and that plugin casts the android extension
# to BaseExtension, which the new DSL drops. Both flags go away in AGP 10.
android.builtInKotlin=false
android.newDsl=false
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ androidxCore = "1.10.1"

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }

[libraries]
Expand Down
1 change: 0 additions & 1 deletion examples/MagicWeatherCompose/app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose.compiler)
}

Expand Down
1 change: 0 additions & 1 deletion examples/MagicWeatherCompose/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
alias(libs.plugins.android.application).apply(false)
alias(libs.plugins.kotlin.android).apply(false)
alias(libs.plugins.compose.compiler).apply(false)
}
5 changes: 0 additions & 5 deletions examples/MagicWeatherCompose/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,3 @@ kotlin.code.style=official
# resources declared in the library itself and none from the library's dependencies,
# thereby reducing the size of the R class for that library
android.nonTransitiveRClass=true

# Built-in Kotlin rejects the kotlin-android plugin, and that plugin casts the android extension
# to BaseExtension, which the new DSL drops. Both flags go away in AGP 10.
android.builtInKotlin=false
android.newDsl=false
1 change: 0 additions & 1 deletion examples/MagicWeatherCompose/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ androidxCore = "1.10.1"

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }

[libraries]
Expand Down
1 change: 0 additions & 1 deletion examples/rcttester/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose.compiler)
alias(libs.plugins.kotlin.serialization)
}
Expand Down
1 change: 0 additions & 1 deletion examples/web-purchase-redemption-sample/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose.compiler)
}

Expand Down
2 changes: 1 addition & 1 deletion feature/galaxy/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ dependencies {

implementation(libs.samsung.iap)
testImplementation(libs.bundles.test)
testImplementation(libs.kotlin.test)
testImplementation(libs.kotlin.test.junit)
}
4 changes: 0 additions & 4 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,3 @@ org.gradle.jvmargs=-Xmx4096M -XX:MaxMetaspaceSize=1g -Dfile.encoding=UTF-8

# Enable the Gradle build cache (local task-output cache) for the main build.
org.gradle.caching=true

# backwards compatibility flags for AGP9, to be enabled in a future PR
android.builtInKotlin=false
android.newDsl=false
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ amazon = "3.0.5"
androidxCardView = "1.0.0"
androidxConstraintLayout = "2.1.3"
androidxCore = "1.8.0"
androidxNavigation = "2.5.3"
androidxNavigation = "2.9.8"
annotation = "1.3.0"
annotationExperimental = "1.5.1"
appcompat = "1.4.1"
Expand Down Expand Up @@ -161,6 +161,7 @@ google-mobile-ads = { module = "com.google.android.gms:play-services-ads", versi
hamcrest-core = { module = "org.hamcrest:hamcrest-core", version.ref = "hamcrest" }

kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }
kotlin-test-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit", version.ref = "kotlin" }
kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinxSerializationJSON" }

material = { module = "com.google.android.material:material", version.ref = "material" }
Expand Down Expand Up @@ -194,7 +195,6 @@ dependencyGraph = { id = "com.savvasdalkitsis.module-dependency-graph", version.
detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }
dokka = { id ="org.jetbrains.dokka", version.ref = "dokka"}
emerge = { id = "com.emergetools.android", version.ref = "emergeGradlePlugin" }
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
kotlin-parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" }
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
Expand Down
9 changes: 3 additions & 6 deletions purchases/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,11 @@ fun DokkaSourceSetSpec.configureDocumentedSourceSet() {

dokka {
dokkaSourceSets {
named("customEntitlementComputation") {
// AGP registers variant source sets after this block runs, so they can only be reached lazily.
matching { it.name.startsWith("customEntitlementComputation") }.configureEach {
suppress.set(true)
}
named("defaults") {
dependentSourceSets.addLater(dokkaSourceSets.named("main").flatMap { it.sourceSetId })
configureDocumentedSourceSet()
}
named("main") {
matching { it.name == "defaultsRelease" }.configureEach {
configureDocumentedSourceSet()
sourceLink {
localDirectory.set(file("src/main/kotlin"))
Expand Down
1 change: 0 additions & 1 deletion test-apps/e2etests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import java.util.Properties

plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.compose.compiler)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
}

android {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.emerge)
alias(libs.plugins.compose.compiler)
}
Expand Down
8 changes: 0 additions & 8 deletions ui/debugview/api.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,3 @@ package com.revenuecat.purchases.ui.debugview {

}

package com.revenuecat.purchases.ui.debugview.models {

public final class InternalDebugRevenueCatScreenViewModelFactory extends androidx.lifecycle.ViewModelProvider.NewInstanceFactory {
ctor public InternalDebugRevenueCatScreenViewModelFactory(kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.models.StoreTransaction,kotlin.Unit> onPurchaseCompleted, kotlin.jvm.functions.Function1<? super com.revenuecat.purchases.PurchasesTransactionException,kotlin.Unit> onPurchaseErrored);
}

}

6 changes: 2 additions & 4 deletions ui/revenuecatui/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,8 @@ dependencies {

dokka {
dokkaSourceSets {
named("defaults") {
dependentSourceSets.addLater(dokkaSourceSets.named("main").flatMap { it.sourceSetId })
}
named("main") {
// AGP registers variant source sets after this block runs, so they can only be reached lazily.
matching { it.name == "defaultsRelease" }.configureEach {
Comment thread
tonidero marked this conversation as resolved.
reportUndocumented.set(true)
skipDeprecated.set(true)

Expand Down