Skip to content

[8.8] [MOD-18346] Backport CI runner fixes and Debian Trixie - #1043

Merged
GuyAv46 merged 2 commits into
8.8from
backport-1032-to-8.8
Sep 8, 2026
Merged

[8.8] [MOD-18346] Backport CI runner fixes and Debian Trixie#1043
GuyAv46 merged 2 commits into
8.8from
backport-1032-to-8.8

Conversation

@GuyAv46

@GuyAv46 GuyAv46 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Combined backport of #1032 and #1031 to 8.8. Both fixes are included so CI can validate and merge them together.

  • Tag coverage and benchmark EC2 runners at launch with team=ai_and_search and a normalized GitHub actor as owner.
  • Run ARM unit tests on GitHub-hosted ubuntu-22.04-arm and remove ARM EC2 provisioning and inherited secrets.
  • Replace active Bullseye CI jobs with gcc:14-trixie, rename the Debian installer/workflow, and update workflow dependencies. Preserve release-specific AWS settings and test options.

Fixes MOD-18346.

Validation: parsed workflow YAML, checked local reusable-workflow paths and job dependencies, verified no active Bullseye jobs remain, compiled owner-tag Python, checked EC2 launch tags, and ran shell syntax/whitespace checks. Runtime CI is pending.


Note

Medium Risk
Changes the CI platform matrix (ARM runner type and Debian version) and AWS EC2 launch metadata, which can affect whether jobs pass or how cloud resources are attributed, but does not touch application runtime code.

Overview
Backports CI fixes for the 8.8 branch: EC2 runner tagging, ARM on GitHub-hosted runners, and Debian Trixie replacing Bullseye in the active matrix.

Coverage and benchmark EC2 flows now derive a sanitized owner tag from github.actor and pass aws-resource-tags (team=ai_and_search, owner=…) when starting runners via machulav/ec2-github-runner.

ARM unit tests no longer provision/stop dedicated EC2 runners or inherit AWS secrets; arm.yml delegates to task-unit-test.yml with env: ubuntu-22.04-arm.

Debian CI switches from Bullseye/debian11.yml to debian13.yml using the gcc:14-trixie container (workflow renamed to “debian trixie flow”). Merge-queue and nightly workflows call the new job (trixie) and drop secrets: inherit on the arm reusable workflow call.

Reviewed by Cursor Bugbot for commit 3c79bb5. Bugbot is set up for automated code reviews on this repo. Configure here.

* [MOD-18346] Tag EC2 CI runners to prevent automatic shutdowns

* Clarify actor source and normalize EC2 owner tags in Python

* Use GitHub-hosted ARM runner for unit tests

(cherry picked from commit 4941539)
@GuyAv46
GuyAv46 requested a review from dor-forer September 8, 2026 06:28
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (45daaf3) to head (3c79bb5).

Additional details and impacted files
@@            Coverage Diff             @@
##              8.8    #1043      +/-   ##
==========================================
- Coverage   97.12%   97.09%   -0.03%     
==========================================
  Files         141      141              
  Lines        8164     8164              
==========================================
- Hits         7929     7927       -2     
- Misses        235      237       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dor-forer
dor-forer previously approved these changes Sep 8, 2026
@GuyAv46 GuyAv46 changed the title [8.8] [MOD-18346] Tag EC2 CI runners and use GitHub-hosted ARM tests [8.8] [MOD-18346] Backport CI runner fixes and Debian Trixie Sep 8, 2026
@GuyAv46
GuyAv46 enabled auto-merge September 8, 2026 08:25
@GuyAv46
GuyAv46 added this pull request to the merge queue Sep 8, 2026
Merged via the queue into 8.8 with commit e9f073e Sep 8, 2026
23 of 25 checks passed
@GuyAv46
GuyAv46 deleted the backport-1032-to-8.8 branch September 8, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants