[0.8] [MOD-18346] Backport CI runner fixes and Debian Trixie - #1039
Merged
Conversation
* [MOD-18346] Tag EC2 CI runners to prevent automatic shutdowns * Clarify actor source and normalize EC2 owner tags in Python * Use GitHub-hosted ARM runner for unit tests (cherry picked from commit 4941539)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.8 #1039 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 91 91
Lines 4896 4896
=======================================
Hits 4757 4757
Misses 139 139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dor-forer
previously approved these changes
Sep 8, 2026
(cherry picked from commit 5d9c4fd)
GuyAv46
enabled auto-merge
September 8, 2026 07:56
dor-forer
previously approved these changes
Sep 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
dor-forer
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined backport of #1032 and #1031 to
0.8. Both fixes are included so CI can validate and merge them together.team=ai_and_searchand a normalized GitHub actor asowner.ubuntu-22.04-armand remove ARM EC2 provisioning and inherited secrets.gcc:14-trixie, rename the Debian installer/workflow, and update workflow dependencies. Preserve release-specific AWS settings and test options.Fixes MOD-18346.
Validation: parsed workflow YAML, checked local reusable-workflow paths and job dependencies, verified no active Bullseye jobs remain, compiled owner-tag Python, checked EC2 launch tags, and ran shell syntax/whitespace checks. Runtime CI is pending.
Note
Low Risk
Changes are limited to CI workflows and test expectations; no production vector-search logic is modified, though CI matrix and EC2 tagging behavior will change on merge.
Overview
CI infrastructure shifts ARM unit tests from ephemeral EC2 runners to GitHub-hosted
ubuntu-22.04-arm, dropping start/stop jobs and the need to pass AWS secrets intoarm.ymlfrom merge-queue and nightly flows.Coverage and benchmark EC2 launches now tag instances with
team=ai_and_searchand a sanitizedownerderived fromgithub.actorvia a small Python normalization step beforemachulav/ec2-github-runnerstarts.Debian CI replaces active Bullseye jobs with Trixie (
gcc:14-trixie):debian13.ymlis renamed/retargeted, and merge-queue, nightly, andflow-tempwiretrixieinstead ofbullseye/debian11.FP16 unit tests in
test_overrideandtest_batch_iterator_basicscale vector values by0.1to stay under FP16 range limits on ARM/SVE, and override score checks useASSERT_NEARwith ~0.2% tolerance instead of exact equality.Reviewed by Cursor Bugbot for commit 36d1fb3. Bugbot is set up for automated code reviews on this repo. Configure here.
Additional merge-queue fix: backport the FP16 test-data scaling from #884 (MOD-13429), already used on newer release branches. This keeps squared L2 distances within FP16 range on the hosted ARM runner; no production distance kernels are changed.