Skip to content

[0.6] [MOD-18346] Backport CI runner fixes and Debian Trixie - #1037

Merged
GuyAv46 merged 3 commits into
0.6from
backport-1032-to-0.6
Sep 8, 2026
Merged

[0.6] [MOD-18346] Backport CI runner fixes and Debian Trixie#1037
GuyAv46 merged 3 commits into
0.6from
backport-1032-to-0.6

Conversation

@GuyAv46

@GuyAv46 GuyAv46 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Combined backport of #1032 and #1031 to 0.6. Both fixes are included so CI can validate and merge them together.

  • Tag coverage and benchmark EC2 runners at launch with team=ai_and_search and a normalized GitHub actor as owner.
  • Run ARM unit tests on GitHub-hosted ubuntu-22.04-arm and remove ARM EC2 provisioning and inherited secrets.
  • Replace active Bullseye CI jobs with gcc:14-trixie, rename the Debian installer/workflow, and update workflow dependencies. Preserve release-specific AWS settings and test options.

Also bump Google Benchmark from 1.7.0 to 1.8.0, matching the newer release branches. This fixes its thread-safety feature detection on the current macOS toolchain, where missing mutex annotations caused the Release build to fail under -Werror. Explicit macOS Release and ASan validation has been dispatched.

Fixes MOD-18346.

Validation: parsed workflow YAML, checked local reusable-workflow paths and job dependencies, verified no active Bullseye jobs remain, compiled owner-tag Python, checked EC2 launch tags, and ran shell syntax/whitespace checks. Runtime CI is pending.


Note

Medium Risk
Changes which platforms run required CI and how EC2 runners are tagged; misconfiguration could block merges or leave mis-tagged instances, but no application runtime or auth logic is touched.

Overview
Backports CI fixes for the 0.6 line: EC2 runner tagging, simpler ARM testing, Debian Trixie instead of Bullseye, and a Google Benchmark bump.

ARM no longer provisions EC2 start/stop jobs or passes secrets: inherit from merge-queue/nightly callers. Unit tests run on GitHub-hosted ubuntu-22.04-arm via task-unit-test.yml.

Coverage and benchmark EC2 launch steps now derive a sanitized owner tag from github.actor and pass aws-resource-tags (team=ai_and_search, dynamic owner) into machulav/ec2-github-runner.

Debian CI switches active jobs from Bullseye/debian11.yml to trixie using debian13.yml with container gcc:14-trixie; merge-queue pr-validation depends on trixie instead of bullseye.

Build: FetchContent for google/benchmark moves from v1.7.0 to v1.8.0 (macOS Release -Werror / thread-safety detection).

Reviewed by Cursor Bugbot for commit 0826f31. Bugbot is set up for automated code reviews on this repo. Configure here.

* [MOD-18346] Tag EC2 CI runners to prevent automatic shutdowns

* Clarify actor source and normalize EC2 owner tags in Python

* Use GitHub-hosted ARM runner for unit tests

(cherry picked from commit 4941539)
@GuyAv46
GuyAv46 requested review from alonre24 and dor-forer and removed request for alonre24 September 8, 2026 06:11
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (215a313) to head (0826f31).

Additional details and impacted files
@@           Coverage Diff           @@
##              0.6    #1037   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          60       60           
  Lines        3371     3371           
=======================================
  Hits         3213     3213           
  Misses        158      158           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dor-forer
dor-forer previously approved these changes Sep 8, 2026
@GuyAv46
GuyAv46 added this pull request to the merge queue Sep 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 8, 2026
@GuyAv46 GuyAv46 changed the title [0.6] [MOD-18346] Tag EC2 CI runners and use GitHub-hosted ARM tests [0.6] [MOD-18346] Backport CI runner fixes and Debian Trixie Sep 8, 2026
@GuyAv46
GuyAv46 enabled auto-merge September 8, 2026 07:56
dor-forer
dor-forer previously approved these changes Sep 8, 2026
@GuyAv46
GuyAv46 added this pull request to the merge queue Sep 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 8, 2026
@GuyAv46
GuyAv46 added this pull request to the merge queue Sep 8, 2026
@GuyAv46
GuyAv46 removed this pull request from the merge queue due to a manual request Sep 8, 2026
@GuyAv46
GuyAv46 enabled auto-merge September 8, 2026 09:24
@GuyAv46 GuyAv46 closed this Sep 8, 2026
auto-merge was automatically disabled September 8, 2026 09:40

Pull request was closed

@GuyAv46 GuyAv46 reopened this Sep 8, 2026
@GuyAv46
GuyAv46 added this pull request to the merge queue Sep 8, 2026
Merged via the queue into 0.6 with commit 6086503 Sep 8, 2026
30 checks passed
@GuyAv46
GuyAv46 deleted the backport-1032-to-0.6 branch September 8, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants