[Storage] Remove DeclarativeHotplugVolumes feature gate enablement

[jpeimer]

What this PR does / why we need it:

The DeclarativeHotplugVolumes feature gate is now enabled by default, so explicit enablement via HCO patching is no longer needed.

Jira: https://redhat.atlassian.net/browse/CNV-84681

Assisted-by: Claude noreply@anthropic.com

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Removed obsolete declarative hotplug feature-gate setup from storage and upgrade test coverage.
  • Updated the pre-upgrade hotplug test to run without the removed setup.
  • No changes to end-user functionality.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 67de1336-d30e-4e7a-acc4-d0c1e2fd559a

📥 Commits

Reviewing files that changed from the base of the PR and between 63653b8 and 2d32584.

📒 Files selected for processing (1)

• tests/storage/test_hotplug.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• RedHatQE/openshift-virtualization-tests-design-docs (manual)

---

📝 Walkthrough

Walkthrough

Changes

Storage hotplug fixture cleanup

Layer / File(s)	Summary
Hotplug test marker cleanup tests/storage/test_hotplug.py	Removes declarative hotplug imports and the module-level fixture marker.
Upgrade fixture cleanup tests/storage/upgrade/conftest.py, tests/storage/upgrade/test_upgrade_storage.py	Removes the feature-gate fixture, reconciliation imports, and fixture parameter from the pre-upgrade test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 2d325

The change removes explicit feature-gate enablement from storage test setup because the gate is enabled by default; no actionable merge-blocking risk remains after normal checks and review.

Possibly related issues

• [Storage] Remove DeclarativeHotplugVolumes feature gate enablement - 5987 #5988: Removes the same declarative hotplug feature-gate fixtures and their usage.

Possibly related PRs

• RedHatQE/openshift-virtualization-tests#4928: Modifies the same declarative hotplug fixture and upgrade test usage.
• RedHatQE/openshift-virtualization-tests#5777: Modifies the fixtures removed by this pull request.
• RedHatQE/openshift-virtualization-tests#5958: Modifies declarative hotplug feature-gate handling in the same storage test files.

Suggested reviewers: ahmad-hafe, vsibirsk, acinko-rh, hmeir

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is under 120 characters and clearly states that the DeclarativeHotplugVolumes feature-gate enablement is being removed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Pr Template Sections	✅ Passed	The live PR body contains all four required headings, and the first section has meaningful text explaining the default feature-gate change.
Stp Link Required	✅ Passed	The PR diff against main contains only 38 deletions in three existing test files; it adds no test files or def test_* functions.
Stp Scenario Coverage	✅ Passed	The changed test_hotplug.py retains valid Jira links in the affected class/test docstrings; test_upgrade_storage.py has no STP/Jira/RFE reference requiring this check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-virtualization-qe-bot-3]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (PR author or approvers)
• /hold cancel - Unblock PR merging (PR author or approvers)
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• jpeimer
• myakove
• rnetser
• vsibirsk

Reviewers:

• Acedus
• Ahmad-Hafe
• Dsanatar
• RoniKishner
• acinko-rh
• akalenyu
• awels
• dalia-frank
• dshchedr
• ema-aka-young
• hmeir
• josemacassan
• jpeimer
• kgoldbla
• kshvaika
• rlobillo
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

• /test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
• /rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

[openshift-virtualization-qe-bot-3]

/retest all

Auto-triggered: Files in this PR were modified by merged PR #5708.

Overlapping files

tests/storage/test_hotplug.py