CherryPicked: [cnv-4.19] net, tests, hot-plug: W/A guest-agent deadlock on hot-plugged interfaces - #5967
Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
Conversation
…ces (#5584) CNV-77961 causes guest-agent to stop reporting newly hot-plugged interfaces, failing tests that depend on interface data from VMI status. This changes works around the partial VMI status report by validating the interface from the guest console, so tests continue to run until the issue is fixed. This flow is valid because it reflects user's behavior - users (and their tools) don't necessarily inspect the openshift resources (VMI status) for checking guest components, but rather might do that directly via the guest. As part of this change, functionality from another package (user_defined_network/ip_specification) was re-used, therefore this package is handled here as well, including a race fix by explicitly checking the interfaces are available. Originally composed by: Anat Wax <awax@redhat.com> Assisted-by: Claude <noreply@anthropic.com> Assisted-by: Yossi Segev <ysegev@redhat.com> CNV-77961 https://redhat.atlassian.net/browse/CNV-88390 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Bug Fixes** - Improved discovery of hot-plugged network interfaces when guest-agent information is unavailable. - Added console-based fallback for verifying secondary IPv4 addresses. - Added retries and clearer error handling when interfaces or addresses cannot be found. - Improved detection of malformed network information and mismatched IPv4 addresses. - **Refactor** - Consolidated guest IPv4 address detection into a shared networking utility. - Updated network validation tests to use the shared behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Anat Wax <awax@redhat.com> Signed-off-by: Yossi Segev <awax@redhat.com>
|
@yossisegev — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging. |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
📌 Additional InformationCustom Commands:
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot-4
requested review from
Anatw,
azhivovk,
frenzyfriday and
servolkov
August 11, 2026 11:57
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #5584, PR owner: yossisegev