PoC: use hummingbird images

[MichaelMraka]

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

Summary by Sourcery

Switch the build and runtime containers to Hummingbird-based Go and Python builder images and adjust the multi-stage Docker build accordingly.

Enhancements:

• Split the Docker multi-stage build into separate Go and Python builder stages and reuse the Python builder as the runtime base image.
• Adjust runtime dependencies, Python RPM path symlinks, user configuration, and data directory handling for the new base images.
• Update the Go module replace directive to point to a new gorpm fork.
• Align the test docker-compose configuration with the renamed Python build stage.

[sourcery-ai]

Reviewer's Guide

Refactors the Docker build and runtime images to use hummingbird Go and Python builder images, splits Go and Python build stages, updates runtime user and filesystem layout, adjusts test compose target, and points the Go module to a new gorpm replacement fork.

File-Level Changes

Change	Details	Files
Refactor Docker build stages to use separate hummingbird Go and Python builder images instead of a single ubi-minimal build image.	Change initial build stage base image to hi/go:1.25.9-builder and name it go-builder Remove Go/Python/Rust toolchain installation from the generic build stage, relying on the Go builder image’s preinstalled toolchain Introduce a new python-builder stage based on hi/python:3.12.13-builder with required RPMs and build tooling Ensure both builder stages run as root and set up the workdir and data directory appropriately	Dockerfile
Update runtime image to use a hummingbird Python builder base, adjust installed RPMs and Python RPM bindings, and change ownership and user model.	Change runtime base image from ubi-minimal to hi/python:3.12.13-builder and run as root Revise microdnf package list to remove direct python312 install and use postgresql-private-libs instead of libpq Update rpm Python binding symlink to point from python3.14 site-packages to python3.12 site-packages Remove creation of /data and dedicated vmaas user, and instead set final container user to UID 65532 Copy Go binary, Python site-packages, uvicorn, requirements, and data from the new builder stages with root:root ownership	Dockerfile
Align docker-compose test build target with the new python builder stage.	Change the build target for the vmaas service in docker-compose.test.yml from buildimg to python-builder so tests build against the Python builder stage	docker-compose.test.yml
Point Go module dependency replacement for gorpm to a new fork and version.	Update the replace directive for github.com/ezamriy/gorpm to use github.com/MichaelMraka/gorpm with a newer pseudo-version	vmaas-go/go.mod vmaas-go/go.sum

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.