AAP-89195 - feat(frontend): apply-default button applies to all templates - #1243
Open
drodowic wants to merge 1 commit into
Open
AAP-89195 - feat(frontend): apply-default button applies to all templates#1243drodowic wants to merge 1 commit into
drodowic wants to merge 1 commit into
Conversation
…ates Removes the "unreviewed only" framing from the apply-default flow: the button now reads "Apply default to all templates" and the confirmation modal warns that every template's manual time will be overwritten, including ones already reviewed, ending with "Do you want to apply this default value to all templates?". No behavior change to the API call itself — it already POSTs with no body.
Contributor
Code Review: AAP-89195 - feat(frontend): apply-default button applies to all templatesVerdict: READY_FOR_HUMAN_REVIEW No critical or major findings. Copy, Cypress assertion, and empty-body POST match the updated Jira description (all-or-nothing apply, no scope switch). Needs human judgment (not code defects)
Observations, verification results, and optional polish are in the local review notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
button + modal screenshot:


Test plan
npx tsc --noEmitpassesnpx eslintpasses on changed filesapplies default manual time to all templates on confirmand related apply-default specs pass in CIDepends on backend change AAP-89193 (automation-analytics-backend) for
manual_effort_reviewedreset behavior.