Skip to content

AAP-89195 - feat(frontend): apply-default button applies to all templates - #1243

Open
drodowic wants to merge 1 commit into
RedHatInsights:develfrom
drodowic:aap-89195/apply-default-to-all-templates
Open

AAP-89195 - feat(frontend): apply-default button applies to all templates#1243
drodowic wants to merge 1 commit into
RedHatInsights:develfrom
drodowic:aap-89195/apply-default-to-all-templates

Conversation

@drodowic

@drodowic drodowic commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • "Apply default to all unreviewed" button/flow is now all-or-nothing: it always overwrites every template's manual effort time with the tenant default, regardless of prior review status.
  • Button label changed to "Apply default to all templates".
  • Confirmation modal now warns that reviewed templates will be overwritten too, ending with "Do you want to apply this default value to all templates?"
  • No API call shape change — endpoint is still called with no body.

button + modal screenshot:
button
modal

Test plan

  • npx tsc --noEmit passes
  • npx eslint passes on changed files
  • Cypress: applies default manual time to all templates on confirm and related apply-default specs pass in CI
  • Manual: click "Apply default to all templates", confirm modal copy, confirm/cancel both work as expected

Depends on backend change AAP-89193 (automation-analytics-backend) for manual_effort_reviewed reset behavior.

…ates

Removes the "unreviewed only" framing from the apply-default flow: the
button now reads "Apply default to all templates" and the confirmation
modal warns that every template's manual time will be overwritten,
including ones already reviewed, ending with "Do you want to apply
this default value to all templates?". No behavior change to the API
call itself — it already POSTs with no body.
@acruzgon

Copy link
Copy Markdown
Contributor

Code Review: AAP-89195 - feat(frontend): apply-default button applies to all templates

Verdict: READY_FOR_HUMAN_REVIEW
Score: 10.0/10 (Functionality 10, Security 10, Quality 10)

No critical or major findings. Copy, Cypress assertion, and empty-body POST match the updated Jira description (all-or-nothing apply, no scope switch).

Needs human judgment (not code defects)

  1. Stale Jira AC custom fieldAAP-89195 / AAP-89193 AC fields still describe the old switch + apply_to_all: true design. This PR implements the updated description. Align the AC field before using it as a QE gate.
  2. Ship with backend AAP-89193 — the UI now says every template (including reviewed) will be overwritten. The POST body is unchanged. If the old backend still filters to unreviewed rows, the new copy overstates the mutation.

Observations, verification results, and optional polish are in the local review notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants