refactor: remove deprecated AllPodsReadyAndRunning rule

[sarad-rh]

AllPodsReadyAndRunning checked all pods across all namespaces and was replaced by InfraPodsReadyAndRunning which scopes to 27 infrastructure namespaces. The old rule was already disabled in the domain (PDRIVE-806).

Assisted-by: Claude Code (Claude Opus 4.6) noreply@anthropic.com

Summary by CodeRabbit

• Bug Fixes
  • Refined Kubernetes pod readiness validation to focus on critical OpenShift infrastructure namespaces.
  • Updated validation documentation to reflect the narrower scope.
• Tests
  • Updated automated coverage to match the revised infrastructure-focused readiness checks.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 37e37141-5459-455c-a7ea-35f33c2bc47d

📥 Commits

Reviewing files that changed from the base of the PR and between a314469 and 6a6a5d6.

📒 Files selected for processing (3)

• src/in_cluster_checks/domains/k8s_domain.py
• src/in_cluster_checks/rules/k8s/k8s_validations.py
• tests/rules/k8s/test_k8s_validations.py

---

📝 Walkthrough

Walkthrough

The PR replaces the all-namespace pod readiness rule with InfraPodsReadyAndRunning, updates its documentation, removes related obsolete tests, and deletes an outdated domain comment.

Changes

K8s readiness validation

Layer / File(s)	Summary
Narrow pod readiness validation src/in_cluster_checks/rules/k8s/k8s_validations.py, src/in_cluster_checks/domains/k8s_domain.py, tests/rules/k8s/test_k8s_validations.py	The rule is renamed to InfraPodsReadyAndRunning and limited to critical OpenShift infrastructure namespaces. Obsolete rule tests, imports, and comments are removed. The test module docstring is shortened.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 6a6a5

This PR removes a deprecated, already-disabled rule and its associated tests and registration; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• RedHatInsights/incluster-checks#113: Implements the same rule replacement with related domain and test updates.
• RedHatInsights/incluster-checks#128: Modifies the InfraPodsReadyAndRunning rule introduced by this change.

Suggested reviewers: sprizend-rh, hoberger-rh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removal of the deprecated AllPodsReadyAndRunning rule.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a314469). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   86.38%           
=======================================
  Files           ?       57           
  Lines           ?     6567           
  Branches        ?        0           
=======================================
  Hits            ?     5673           
  Misses          ?      894           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.