Skip to content

fix(app): resolve AppEntry TDZ from Kessel circular init - #1965

Closed
diegomaranhao wants to merge 2 commits into
mainfrom
dmaranha/fix-circular-import
Closed

fix(app): resolve AppEntry TDZ from Kessel circular init#1965
diegomaranhao wants to merge 2 commits into
mainfrom
dmaranha/fix-circular-import

Conversation

@diegomaranhao

Copy link
Copy Markdown

What's included

fix(app): resolve AppEntry TDZ from Kessel circular init
Hoist AppEntry as a function declaration and lazy-load App so Chrome can
resolve the federated export before Kessel/auth evaluate. Install
@project-kessel/react-kessel-access-check as a real dependency instead of
an optional peer.

How to test

Example

...

Updates issue/story

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d5fa14e-6161-4c3b-b040-913cc62575bc


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.24%. Comparing base (55cfb7e) to head (393acc8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         127      127           
  Lines        5230     5230           
  Branches     2419     2419           
=======================================
  Hits         4772     4772           
  Misses        421      421           
  Partials       37       37           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55cfb7e...393acc8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diegomaranhao
diegomaranhao force-pushed the dmaranha/fix-circular-import branch from d80b72f to 78dc4bf Compare August 21, 2026 12:34
@diegomaranhao

Copy link
Copy Markdown
Author

/retest

@diegomaranhao
diegomaranhao force-pushed the dmaranha/fix-circular-import branch 3 times, most recently from ad2b7cf to 3998bab Compare August 21, 2026 12:58
Co-authored-by: Cursor <cursoragent@cursor.com>
@diegomaranhao
diegomaranhao force-pushed the dmaranha/fix-circular-import branch from 3998bab to 393acc8 Compare August 21, 2026 13:01
@swatch-ci

Copy link
Copy Markdown

IQE Tests: PASSED -- bonfire-integration-tests-pipelinerun-5jtg9

  • 11 tests ran in 8.2 min
  • 11 passed, 0 failed, 0 skipped
  • IQE image: quay.io/cloudservices/iqe-tests:curiosity

@vbusch vbusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomaranhao can you give more context as to which environment needs this change.
Adding React.lazy adds more complexity.

@diegomaranhao diegomaranhao left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbusch I was having a circular issue before with the fix of #1972 to run it on stage proxy npm run start:proxy , but the last changes seem to have fixed the issue. I'm closing this PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants