fix(app): resolve AppEntry TDZ from Kessel circular init - #1965
fix(app): resolve AppEntry TDZ from Kessel circular init#1965diegomaranhao wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 127 127
Lines 5230 5230
Branches 2419 2419
=======================================
Hits 4772 4772
Misses 421 421
Partials 37 37 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
d80b72f to
78dc4bf
Compare
|
/retest |
ad2b7cf to
3998bab
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
3998bab to
393acc8
Compare
|
IQE Tests: PASSED --
|
vbusch
left a comment
There was a problem hiding this comment.
@diegomaranhao can you give more context as to which environment needs this change.
Adding React.lazy adds more complexity.
What's included
fix(app): resolve AppEntry TDZ from Kessel circular init
Hoist AppEntry as a function declaration and lazy-load App so Chrome can
resolve the federated export before Kessel/auth evaluate. Install
@project-kessel/react-kessel-access-check as a real dependency instead of
an optional peer.
How to test
Example
...
Updates issue/story