Skip to content

Allow missing end-of-compression labels on history points - #222

Merged
alongd merged 1 commit into
mainfrom
history-points-optional-eoc-state
Oct 3, 2026
Merged

alongd merged 1 commit into
mainfrom
history-points-optional-eoc-state

Conversation

@alongd

@alongd alongd commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

  • allow version-1 volume-history RCM points to omit end-of-compression temperature and pressure labels
  • retain supplied labels and emit null comparison labels when omitted
  • document the conditional requirement and cover schema/comparison behavior

Verification

  • Targeted coverage run: 592 passed (experimental-IDT, schema, and tests importing edited modules).
  • Local full-suite exclusions reproduced on untouched official/main worktree /home/alon/Code/T3-i113-schema-ref at 1dae24c:
    • tests/test_functional.py::test_computing_thermo fails because RMG does not generate chem_annotated.yaml.
    • tests/test_utils/test_flux.py::test_generate_flux fails because Graphviz dot is absent from PATH.
    • Captured main-reproduction stdout/stderr: /home/alon/runs/i118-t3/main-{functional,flux}.{stdout,stderr}.log.

CI is the authority for the full suite.

@github-actions
github-actions Bot requested a balanced review from Copilot October 3, 2026 08:57
@codecov-commenter

codecov-commenter commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.91%. Comparing base (35fc9d6) to head (18d6e77).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   81.92%   81.91%   -0.01%     
==========================================
  Files          78       78              
  Lines       12943    12947       +4     
  Branches     2731     2732       +1     
==========================================
+ Hits        10603    10605       +2     
- Misses       1694     1695       +1     
- Partials      646      647       +1     
Flag Coverage Δ
unittests 81.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation, tests, and documentation consistently preserve existing behavior while supporting omitted history-point labels.

Review effort: Balanced
Findings: None

What changed in this PR

Allows history-driven RCM experiments to omit compressed-state temperature and pressure labels while preserving existing history-free requirements.

Changes:

  • Makes compressed-state labels conditionally optional.
  • Emits None for omitted comparison labels.
  • Adds tests and documentation for the updated schema.
File Description
t3/​schema.py Adds conditional label validation.
t3/​simulate/​cantera_idt.py Handles omitted labels in comparison output.
tests/​test_simulate/​test_experimental_idt.py Tests schema and simulation behavior.
docs/​input_reference.md Documents conditional requirements.
docs/​examples.md Clarifies RCM label semantics.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alongd
alongd force-pushed the history-points-optional-eoc-state branch from bffe4b7 to 18d6e77 Compare October 3, 2026 09:21
@alongd
alongd requested a balanced review from Copilot October 3, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation consistently updates validation, comparison output, documentation, and targeted tests without introducing unresolved issues.

Review effort: Balanced
Findings: None

@alongd
alongd merged commit 4043bb9 into main Oct 3, 2026
5 checks passed
@alongd
alongd deleted the history-points-optional-eoc-state branch October 3, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants