Repository navigation
Allow missing end-of-compression labels on history points - #222
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 81.92% 81.91% -0.01%
==========================================
Files 78 78
Lines 12943 12947 +4
Branches 2731 2732 +1
==========================================
+ Hits 10603 10605 +2
- Misses 1694 1695 +1
- Partials 646 647 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, tests, and documentation consistently preserve existing behavior while supporting omitted history-point labels.
Review effort: Balanced
Findings: None
What changed in this PR
Allows history-driven RCM experiments to omit compressed-state temperature and pressure labels while preserving existing history-free requirements.
Changes:
- Makes compressed-state labels conditionally optional.
- Emits
Nonefor omitted comparison labels. - Adds tests and documentation for the updated schema.
| File | Description |
|---|---|
t3/schema.py |
Adds conditional label validation. |
t3/simulate/cantera_idt.py |
Handles omitted labels in comparison output. |
tests/test_simulate/test_experimental_idt.py |
Tests schema and simulation behavior. |
docs/input_reference.md |
Documents conditional requirements. |
docs/examples.md |
Clarifies RCM label semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bffe4b7 to
18d6e77
Compare
Summary
Verification
CI is the authority for the full suite.