Skip to content

refactor(hipsparse): Remove old definitions in hipsparse_test_enum.hpp - #12087

Open
amontoison wants to merge 1 commit into
ROCm:developfrom
amontoison:remove_old_feature_flags
Open

amontoison wants to merge 1 commit into
ROCm:developfrom
amontoison:remove_old_feature_flags

Conversation

@amontoison

Copy link
Copy Markdown
Contributor

Follow-up PR for #11265.

JIRA ID: AISPARSE-760

@therock-pr-bot

therock-pr-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hipsparse/clients/tests/hipsparse_test_enum.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12087   +/-   ##
========================================
  Coverage    70.24%   70.24%           
========================================
  Files         2812     2812           
  Lines       462648   462648           
  Branches     68101    68101           
========================================
  Hits        324985   324985           
  Misses      114135   114135           
  Partials     23528    23528           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 46.40% <ø> (ø) Carriedforward from 69283dd
TensileLite-Unit 76.06% <ø> (ø) Carriedforward from 69283dd
hipBLAS 90.62% <ø> (ø) Carriedforward from 69283dd
hipBLASLt 35.24% <ø> (ø) Carriedforward from 69283dd
hipCUB 82.68% <ø> (ø) Carriedforward from 69283dd
hipDNN 87.01% <ø> (ø) Carriedforward from 69283dd
hipFFT 43.07% <ø> (ø) Carriedforward from 69283dd
hipRAND 76.12% <ø> (ø) Carriedforward from 69283dd
hipSOLVER 68.92% <ø> (ø) Carriedforward from 69283dd
hipSPARSE 86.99% <ø> (ø)
rocBLAS 48.31% <ø> (ø) Carriedforward from 69283dd
rocFFT 47.30% <ø> (ø) Carriedforward from 69283dd
rocRAND 57.42% <ø> (ø) Carriedforward from 69283dd
rocSOLVER 76.83% <ø> (ø) Carriedforward from 69283dd
rocSPARSE 74.61% <ø> (ø) Carriedforward from 69283dd
rocThrust 91.60% <ø> (ø) Carriedforward from 69283dd

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant