Skip to content

Enable gfx1250-strict for rocWMMA - #12081

Merged
bsyrowik merged 1 commit into
developfrom
users/bsyrowik/gfx1250_strict
Sep 15, 2026
Merged

bsyrowik merged 1 commit into
developfrom
users/bsyrowik/gfx1250_strict

Conversation

@bsyrowik

@bsyrowik bsyrowik commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

The rocWMMA project should support both the gfx1250 and gfx1250-strict targets.

JIRA ID - AIROCWMMA-43

Technical Details

For rocWMMA both the gfx1250 and gfx1250-strict targets are equivalent; enable compiling for gfx1250-strict using the existing gfx1250 code paths.

Test Plan

  • Configure and compile for gfx1250-strict alongside gfx1250.
  • CI.

Test Result

  • Configure and compile worked as expected -- both targets are generated.
  • Waiting on CI.

Submission Checklist

@bsyrowik
bsyrowik requested a review from a team as a code owner September 14, 2026 23:06
@bsyrowik bsyrowik changed the title Enable gfx1250-strict on rocWMMA Enable gfx1250-strict for rocWMMA Sep 14, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocwmma/library/include/rocwmma/internal/config.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@evedovelli evedovelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsyrowik
bsyrowik merged commit a3cac2b into develop Sep 15, 2026
210 of 224 checks passed
@bsyrowik
bsyrowik deleted the users/bsyrowik/gfx1250_strict branch September 15, 2026 15:12
assistant-librarian Bot pushed a commit to ROCm/rocWMMA that referenced this pull request Sep 15, 2026
Enable gfx1250-strict for rocWMMA

## Motivation

The rocWMMA project should support both the gfx1250 and gfx1250-strict
targets.

JIRA ID - AIROCWMMA-43

## Technical Details

For rocWMMA both the gfx1250 and gfx1250-strict targets are equivalent;
enable compiling for gfx1250-strict using the existing gfx1250 code
paths.

## Test Plan

 * Configure and compile for gfx1250-strict alongside gfx1250.
 * CI.

## Test Result

* Configure and compile worked as expected -- both targets are
generated.
 * Waiting on CI.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants