refactor(rocsparse): Remove the rocBLAS dependency from rocSPARSE - #12076
Draft
amontoison wants to merge 4 commits into
Draft
amontoison wants to merge 4 commits into
amontoison wants to merge 4 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
amontoison
marked this pull request as draft
September 14, 2026 22:03
amontoison
force-pushed
the
rocsparse-drop-rocblas-dependency
branch
from
September 14, 2026 22:03
56e9773 to
257017c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12076 +/- ##
===========================================
+ Coverage 70.25% 70.35% +0.10%
===========================================
Files 2810 2808 -2
Lines 462525 461789 -736
Branches 68082 67958 -124
===========================================
- Hits 324920 324866 -54
+ Misses 114086 113463 -623
+ Partials 23519 23460 -59
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocSPARSEdepends onrocBLASfor a single function,rocblas_gemm_ex, reached through an internal shim.It is used only by
rocsparse_sddmm_alg_dense, which densifies the sparse output and calls a dense GEMM.Every other routine, including the default SDDMM algorithm, has a native kernel.
Drop the dependency and map
rocsparse_sddmm_alg_denseontorocsparse_sddmm_alg_default.The enum value stays valid and keeps its numerical value, so existing sources and binaries keep working.
It is simply documented as deprecated.
JIRA ID: AISPARSE-765