test(hipblaslt): expand complex batch gtest coverage [bkc 20260908] - #12074
Merged
marbre merged 1 commit intoSep 15, 2026
Conversation
JIRA ID : ROCM-30021 ## Motivation Add a complex general-batch edge case covering the pointer-array (batch_mode=1) path over degenerate/boundary sizes and conjugate transposes, and toggle batch_mode [0, 1] on matmul_batch_medium_complex, to guard [ROCM-30021](https://amd-hub.atlassian.net/browse/ROCM-30021). <!-- Explain the purpose of this PR and the goals it aims to achieve. --> ## Technical Details Add batch_mode: [0, 1] to matmul_batch_medium_complex and one gtest case `matmul_batch_complex_general_batch_edge` reusing existing anchors (`one_matrix_size_range` + `complex_transA_transB_range`), covering batch_mode [0, 1]. No source changes. <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan `hipblaslt-test --gtest_filter=*matmul*complex*` on gfx1250. <!-- Explain any relevant testing done to verify this PR. --> ## Test Result 8684 complex tests pass, 0 failures (verified on develop branch that includes #11334). <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. [ROCM-30021]: https://amd-hub.atlassian.net/browse/ROCM-30021?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: mengzcai <mengzcai@amd.com> (cherry picked from commit a873b5e)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/bkc/therock-10.1-20260908 #12074 +/- ##
====================================================================
Coverage ? 64.11%
====================================================================
Files ? 2826
Lines ? 469784
Branches ? 69375
====================================================================
Hits ? 301200
Misses ? 147469
Partials ? 21115
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM. |
mengzcai
approved these changes
Sep 15, 2026
marbre
approved these changes
Sep 15, 2026
marbre
left a comment
Member
There was a problem hiding this comment.
Approving on behalf of DevOps.
marbre
merged commit Sep 15, 2026
458e811
into
release/bkc/therock-10.1-20260908
190 of 202 checks passed
marbre
deleted the
users/astyrrian1/bkc-20260908-ROCM-30021-pr-11653
branch
September 15, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11653
Source commit:
a873b5eb2ab4cd7d58b4e2f3e3a42e64640e14faJIRA ID : ROCM-30021
Motivation
Add a complex general-batch edge case covering the pointer-array
(batch_mode=1) path over degenerate/boundary sizes and conjugate
transposes, and toggle batch_mode [0, 1] on matmul_batch_medium_complex,
to guard ROCM-30021.
Technical Details
Add batch_mode: [0, 1] to matmul_batch_medium_complex and one gtest case
matmul_batch_complex_general_batch_edgereusing existinganchors (
one_matrix_size_range+complex_transA_transB_range), coveringbatch_mode [0, 1]. No source changes.
Test Plan
hipblaslt-test --gtest_filter=*matmul*complex*on gfx1250.Test Result
8684 complex tests pass, 0 failures (verified on develop branch that includes #11334).
Submission Checklist