Skip to content

test(hipblaslt): expand complex batch gtest coverage [bkc 20260908] - #12074

Merged
marbre merged 1 commit into
release/bkc/therock-10.1-20260908from
users/astyrrian1/bkc-20260908-ROCM-30021-pr-11653
Sep 15, 2026
Merged

marbre merged 1 commit into
release/bkc/therock-10.1-20260908from
users/astyrrian1/bkc-20260908-ROCM-30021-pr-11653

Conversation

@astyrrian1

@astyrrian1 astyrrian1 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

#11653
Source commit: a873b5eb2ab4cd7d58b4e2f3e3a42e64640e14fa

JIRA ID : ROCM-30021

Motivation

Add a complex general-batch edge case covering the pointer-array
(batch_mode=1) path over degenerate/boundary sizes and conjugate
transposes, and toggle batch_mode [0, 1] on matmul_batch_medium_complex,
to guard ROCM-30021.

Technical Details

Add batch_mode: [0, 1] to matmul_batch_medium_complex and one gtest case matmul_batch_complex_general_batch_edge reusing existing
anchors (one_matrix_size_range + complex_transA_transB_range), covering
batch_mode [0, 1]. No source changes.

Test Plan

hipblaslt-test --gtest_filter=*matmul*complex* on gfx1250.

Test Result

8684 complex tests pass, 0 failures (verified on develop branch that includes #11334).

Submission Checklist

JIRA ID : ROCM-30021

## Motivation
Add a complex general-batch edge case covering the pointer-array
(batch_mode=1) path over degenerate/boundary sizes and conjugate
transposes, and toggle batch_mode [0, 1] on matmul_batch_medium_complex,
to guard [ROCM-30021](https://amd-hub.atlassian.net/browse/ROCM-30021).
<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

## Technical Details
Add batch_mode: [0, 1] to matmul_batch_medium_complex and one gtest case
`matmul_batch_complex_general_batch_edge` reusing existing
anchors (`one_matrix_size_range` + `complex_transA_transB_range`),
covering
batch_mode [0, 1]. No source changes.
<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan
`hipblaslt-test --gtest_filter=*matmul*complex*` on gfx1250.
<!-- Explain any relevant testing done to verify this PR. -->

## Test Result
8684 complex tests pass, 0 failures (verified on develop branch that
includes #11334).
<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[ROCM-30021]:
https://amd-hub.atlassian.net/browse/ROCM-30021?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: mengzcai <mengzcai@amd.com>
(cherry picked from commit a873b5e)
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@                         Coverage Diff                          @@
##             release/bkc/therock-10.1-20260908   #12074   +/-   ##
====================================================================
  Coverage                                     ?   64.11%           
====================================================================
  Files                                        ?     2826           
  Lines                                        ?   469784           
  Branches                                     ?    69375           
====================================================================
  Hits                                         ?   301200           
  Misses                                       ?   147469           
  Partials                                     ?    21115           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.57% <ø> (?)
TensileLite-Unit 75.61% <ø> (?)
hipBLAS 90.62% <ø> (?) Carriedforward from 271344a
hipBLASLt 35.29% <ø> (?)
hipCUB 82.68% <ø> (?) Carriedforward from 271344a
hipDNN 86.95% <ø> (?) Carriedforward from 271344a
hipFFT 42.66% <ø> (?) Carriedforward from 271344a
hipRAND 76.12% <ø> (?) Carriedforward from 271344a
hipSOLVER 68.92% <ø> (?) Carriedforward from 271344a
hipSPARSE 86.99% <ø> (?) Carriedforward from 271344a
rocBLAS 0.28% <ø> (?) Carriedforward from 271344a
rocFFT 51.25% <ø> (?) Carriedforward from 271344a
rocRAND 56.91% <ø> (?) Carriedforward from 271344a
rocSOLVER 76.83% <ø> (?) Carriedforward from 271344a
rocSPARSE 74.61% <ø> (?) Carriedforward from 271344a
rocThrust 91.60% <ø> (?) Carriedforward from 271344a

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mengzcai

Copy link
Copy Markdown
Contributor

LGTM.
One request: this test coverage is based on PR #13344, so please make sure release/bkc/therock-10.1-20260908 also includes #13344 — otherwise the new tests will fail on that branch.

@astyrrian1
astyrrian1 marked this pull request as ready for review September 15, 2026 15:28
@astyrrian1
astyrrian1 requested review from a team September 15, 2026 15:28
@astyrrian1
astyrrian1 requested a review from a team as a code owner September 15, 2026 15:28

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of DevOps.

@marbre
marbre merged commit 458e811 into release/bkc/therock-10.1-20260908 Sep 15, 2026
190 of 202 checks passed
@marbre
marbre deleted the users/astyrrian1/bkc-20260908-ROCM-30021-pr-11653 branch September 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants