fix: harden evidence publication and offline buyer auditing - #58
Merged
Merged
Conversation
Add Plain/Embedded redaction behind an explicit Context, replace public percent grades with failed/evaluated/skipped counts, emit conformity_claim none on versioned crossing formats, and land schema goldens. Co-authored-by: Cursor <cursoragent@cursor.com>
Curbpack check✅ Gates green — readiness 100%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing evaluated inputs without changing findings could leave identical evidence, and interrupted or escaped writes could produce a misleading review pack. This change binds exact inputs and time, publishes a verifiable completed artifact set, and extends the existing offline review engine to check it.
This successor preserves the commits from #57 and adds the takeover repairs. Review this PR for the combined change; #57 has not been merged or discarded.
.gitand symlink escapes, VEX/SBOM/share output containment, and preparation errors hidden byshare.--as-of, exact pack/input/method identity, immutable digest-addressed objects, verified cache reads and historical adapters. Freshness uses the selected instant; operational metadata stays in receipts.Validation: fresh
go test ./... -count=1, build, vet, affected race tests including review/CLI, gauntlet, claim safety, focused behavioral regressions and actual Action resolver all passed. Public assets passed 17 tests including real Chrome checks; versioned schemas/goldens passed Draft 2020-12 validation. Windows CLI cross-compilation passed. All five published v0.5.5 binaries matched downloaded release checksums; its macOS amd64 installer, installed version and scan were tested separately.Tester instructions and the remaining acceptance boundary are in
docs/production-hardening-audit.md. Test this branch explicitly: the default installer still installs published v0.5.5. Native Linux/Windows installation, broader interruption/fault injection and remaining crossing-format coverage are not claimed complete. Human merge, release, attestation, outreach and pin promotion remain separate; this PR does not assert broad production readiness.Prior-report integrity follow-up at
fb194fe4dcda8b436f0230f7080d2a4613e76552: the shared review engine rejects unsupported schemas and missing or mismatched prior record digests before deriving a trend or linking a child report. Six CLI mutation cases reproduced success before the fix in pack and repository modes; they now exit 2 without JSON output. Historical baselines and existing verify-chain behavior remain supported. Local review/CLI/export suites, review race tests, affected vet, build, repository check and an actual-binary valid/tampered baseline probe passed. All nine GitHub checks passed on this commit: Ubuntu/macOS suites, Linux and Windows smoke, red-team, gauntlet, Action dogfood, pin guard and required-context drift. CI run.Pre-beta acceptance review at
bf61c02: recommend merge for a small, explicitly selected source-build trial after final checks pass. The actualdoctor → scan → check → demo → share --bundle → relocated offline reviewjourney passed with custom HOME/TMPDIR and spaced paths. This uncovered a bundle published after the manifest; the repair now stages and hashes it with the current one-pager. Its regression reproduced red before the fix and now verifies complete coverage plus tamper detection. Controlled process interruption also passed: second writer refused, live recovery refused, killed-owner recovery succeeded, re-emission verified. Fresh full uncached tests, affected races, vet, build, browser tests, real OpenSSH fixture and separate macOS v0.5.5 install smoke passed. All nine final GitHub checks passed onbf61c02cfcf16c3ca68dbbc1c34aabc618785a0d: CI run.The friendly-user handoff records scope, commands and deferred acceptance. Corrected stale v0.5.4 human-runbook instructions. Live social metadata and PNG were checked; Slack/LinkedIn unfurls and independent human comprehension were not claimed. No A2/A3 human pass, merge, release, attestation, outreach or pin promotion was performed.
The additional blank-repository trial passed: write-free scan, redirected
init --bare, expected failing check/share on draft scaffolds, and successful integrity review of the remediation pack. The in-app browser security policy blocked opening the temporary local HTML bundle, so its visual cold-read remains unverified; no workaround was attempted.