fix R3BRoot/r3bbase/R3BFileSource2.h:29:48: error: no template named … - #939
Merged
jose-luis-rs merged 1 commit intoJan 19, 2024
Merged
Conversation
…'optional' in namespace 'std' fix error: invalid use of incomplete type ‘class std::basic_ostream<char>’
Contributor
|
Thanks a lot for the PR. This problem comes from my PR #910 and I had no idea why it compiled successfully both in the CI and lxir136 machine. But I did see it when I tried to compile R3BRoot using gcc12. Which gcc version do you use when you found this issue? Also please create another PR based on dev branch and as it's a small change, we could merge it quickly as well. @jose-luis-rs |
Contributor
Author
|
gcc --version |
Contributor
|
Yeah, that makes sense. In our CI, gcc version is 8.3.0 and probably gcc 8 includes some headers by default and somehow they are not included anymore in newer versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…'optional' in namespace 'std'
fix error: invalid use of incomplete type ‘class std::basic_ostream’
Describe your proposal.
Mention any issue this PR is resolved or is related to.
Checklist:
devbranch