Skip to content

Fixed full width "Other installers" button - #128

Open
0neGal wants to merge 3 commits into
R2Northstar:mainfrom
0neGal:main
Open

Fixed full width "Other installers" button#128
0neGal wants to merge 3 commits into
R2Northstar:mainfrom
0neGal:main

Conversation

@0neGal

@0neGal 0neGal commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

I have no idea if this is intentional, just happened to go on the site to do something completely unrelated, and it didn't seem intentional?

Before
After

(Disregard my system font overriding the text's font family, that's just my browser)

@GeckoEidechse

Copy link
Copy Markdown
Member

It might have been intentional to make the bar more visible? Not sure actually, cc @barnabwhy

I'm fine with both ^^

Comment thread src/components/Installers.astro Outdated
@0neGal

0neGal commented Dec 21, 2024

Copy link
Copy Markdown
Contributor Author

It might have been intentional to make the bar more visible?

If intentional I would put a max-width onto it, as it looks worse and worse the bigger the screen size is...

@barnabwhy

Copy link
Copy Markdown
Contributor

It might have been intentional to make the bar more visible?

If intentional I would put a max-width onto it, as it looks worse and worse the bigger the screen size is...

I'd say chuck a max-width on it or make it full width on small screens with a media query

@0neGal

0neGal commented Dec 22, 2024

Copy link
Copy Markdown
Contributor Author

I'd say chuck a max-width on it or make it full width on small screens with a media query

Up to y'all, is there a pre-existing consensus in the CSS on what's considered a small screen?

@GeckoEidechse

Copy link
Copy Markdown
Member

is there a pre-existing consensus in the CSS on what's considered a small screen?

Don't think so...

I'm fine with anything that you'd consider looks better tbh ^^

@0neGal

0neGal commented Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Made it so it's small on a big screen:
image

And on a screen size where installers are just one column, it's full width:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants