Conversation
Owner
|
How are you testing this? I am unable to get the same result when I test on my production server (hence why I haven't merged) |
Contributor
Author
|
Hey, thanks again for testing! curl -s http://127.0.0.1:8080/browsing | od -An -tx1 -N4
# 1f 8b 08 00 = bad which is compressed/raw response
# 3c 21 64 6f = good "<!do"I tested by starting the build and If you’re still seeing gibberish on the PR, could you run that curl while it’s happening? That should help narrow down what’s different on your side. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
As discussed on the issue, this is the fix for the gzip gibberish after a restart.
The build was deleting the live
views/distfolder while it ran, so a server starting during a build picked up the wrong page loader and kept serving it until the next restart. The build now leaves the current folder in place and only swaps in the new one at the end.Tested with the real build and server: restarting during a build now gives normal pages instead of gibberish, and the build output is unchanged.