fix: keep session stopwatches running while the screen is off - #707
Open
NeiltonGabriel wants to merge 1 commit into
Open
fix: keep session stopwatches running while the screen is off#707NeiltonGabriel wants to merge 1 commit into
NeiltonGabriel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setIntervaltick, and Android suspends JavaScript timers while the screen is off, so every second the device slept was lost for good.session-global-context.tsxto derive their elapsed time from wall-clock anchors (timerStartedAtMs/timerBaseSecondsfor the exercise clock,totalStartedAtMs/totalBaseSecondsfor the session total) instead of incrementing a counter, leaving the interval to only refresh what is displayed.registerSession,toggleTimer,updateTimeElapsed), so pausing still freezes the exercise clock while the session total keeps running, and restarting an exercise still zeroes it.AppStatelistener that recomputes both clocks on the transition back toactive, so the screen catches up the moment the device wakes instead of waiting for the next tick.Stopwatchcomponent's own uncontrolled timer, which carried the identical defect.versioninapp.jsonto 1.1.4.Validation:
npx tsc --noEmit— 0 errors.npm run lint— 0 errors and 7 warnings, all pre-existing and none in the touched files.tickSessionagainst a simulated sleep timeline: five minutes with the screen off while running (310s elapsed, nothing lost), two minutes paused with the screen off (exercise clock frozen at 310s, session total advancing to 430s), resume plus another minute asleep, and the 3h cap on the session total.Date.now()and are unaffected by the change; they now sit on an equally accurate session total.