Skip to content

support td1 - #10

Open
ilya-korotya wants to merge 4 commits into
developfrom
feature/support-td1
Open

support td1#10
ilya-korotya wants to merge 4 commits into
developfrom
feature/support-td1

Conversation

@ilya-korotya

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends passport parsing capabilities to support TD1 (ID card) format in addition to the existing TD3 (passport booklet) format. The implementation automatically detects the document type based on data length and routes to the appropriate parser.

Key Changes:

  • Added ParseTD1 function to parse 3-line TD1 formatted documents (ID cards)
  • Refactored ParseDG1 to automatically detect TD1 vs TD3 format based on byte length
  • Updated test infrastructure with format-specific helper functions and comprehensive TD1 test cases

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
passport/dg1_parser.go Adds ParseTD1 function for TD1 format parsing, refactors ParseDG1 to auto-detect format, extracts ParseTD3 as standalone function
passport/dg1_parser_test.go Splits helper functions into mrzToDg1_TD3 and mrzToDg1_TD1, adds comprehensive TD1 test cases with 10 scenarios
passport/passportV1_test.go Renames existing tests to TD3-specific, adds corresponding TD1 tests for W3C credential generation and input marshaling
passport/testdata/inputs_td1.json Test fixture with expected circuit inputs for TD1 document processing
passport/testdata/inputs_td3.json Test fixture with expected circuit inputs for TD3 document processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread passport/dg1_parser.go Outdated
Comment thread passport/dg1_parser_test.go Outdated
Comment thread passport/dg1_parser.go Outdated
Comment thread passport/dg1_parser_test.go Outdated
Comment thread passport/dg1_parser.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants