support td1 - #10
Open
ilya-korotya wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends passport parsing capabilities to support TD1 (ID card) format in addition to the existing TD3 (passport booklet) format. The implementation automatically detects the document type based on data length and routes to the appropriate parser.
Key Changes:
- Added ParseTD1 function to parse 3-line TD1 formatted documents (ID cards)
- Refactored ParseDG1 to automatically detect TD1 vs TD3 format based on byte length
- Updated test infrastructure with format-specific helper functions and comprehensive TD1 test cases
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
passport/dg1_parser.go |
Adds ParseTD1 function for TD1 format parsing, refactors ParseDG1 to auto-detect format, extracts ParseTD3 as standalone function |
passport/dg1_parser_test.go |
Splits helper functions into mrzToDg1_TD3 and mrzToDg1_TD1, adds comprehensive TD1 test cases with 10 scenarios |
passport/passportV1_test.go |
Renames existing tests to TD3-specific, adds corresponding TD1 tests for W3C credential generation and input marshaling |
passport/testdata/inputs_td1.json |
Test fixture with expected circuit inputs for TD1 document processing |
passport/testdata/inputs_td3.json |
Test fixture with expected circuit inputs for TD3 document processing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daveroga
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.