Support Minecraft 26.1.2 chunk fluid counts - #326
Closed
mneuhaus wants to merge 2 commits into
Closed
Conversation
This was referenced May 12, 2026
mneuhaus
marked this pull request as ready for review
May 12, 2026 14:53
extremeheat
reviewed
Jul 31, 2026
Comment on lines
+196
to
+204
| if (section) { | ||
| const sectionPos = toSectionPos(pos, this.minY) | ||
| if (hasFluidCount) { | ||
| const oldStateId = section.get(sectionPos) | ||
| const oldHasFluid = hasFluidState(oldStateId) | ||
| const newHasFluid = hasFluidState(stateId) | ||
| if (oldHasFluid !== newHasFluid) section.fluidCount += newHasFluid ? 1 : -1 | ||
| } | ||
| section.set(sectionPos, stateId) |
Member
There was a problem hiding this comment.
Since PaletteChunkSection already does bookkeeping on the solid data, there is no need to add the extra logic in the ChunkColumn itself especially as this is section-level data
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Minecraft 26.1.2 chunk compatibility for the updated chunk fluid count layout.
This is part of the 26.1.2 compatibility chain used downstream by Mineflayer and viewer-style consumers.
Testing
Validated locally with:
Evidence summary: https://gist.github.com/mneuhaus/decaae9cd8767a651272d31cdf97ac60
Related PRs
Part of the Minecraft 26.1.2 update chain:
The dependent PRs are opened as drafts so they can be reviewed/merged in order.
Implementation note
Prepared with assistance from GPT-5.5 and validated locally with the checks listed above.