Skip to content

Speed up furnace external test by fast-forwarding CookTime #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rom1504 merged 2 commits into from
Sep 5, 2026
Merged

Speed up furnace external test by fast-forwarding CookTime #3990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03f846c
Speed up furnace external test by fast-forwarding CookTime
u9g Aug 23, 2026
200fac9
test(furnace): gate the NBT fast-forward on minecraft-data features
u9g Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/externalTests/furnace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const assert = require('assert')
const { onceWithCleanup } = require('../../lib/promise_utils')

module.exports = () => async (bot) => {
const Item = require('prismarine-item')(bot.registry)
Expand Down Expand Up @@ -47,7 +48,18 @@ module.exports = () => async (bot) => {
assert(furnace.fuel > 0 && furnace.fuel < 1)
assert(furnace.progress > 0 && furnace.progress < 1)

await bot.test.wait(furnace.progressSeconds * 1000 + 500)
// The furnace only completes on cookTime == totalCookTime (not >=), so the
// merged value must stay below 200.
const { x, y, z } = furnacePos
const cookTimeKey = bot.supportFeature('furnaceNbtUsesSnakeCase') ? 'cooking_time_spent' : 'CookTime'
if (bot.supportFeature('hasDataCommand')) {
bot.chat(`/data merge block ${x} ${y} ${z} {${cookTimeKey}:195s}`)
} else {
bot.chat(`/blockdata ${x} ${y} ${z} {${cookTimeKey}:195s}`)
}
// The 5 remaining ticks complete in 250-320ms on every tested version; a
// timeout means the merge was silently ignored.
await onceWithCleanup(furnace, 'update', { timeout: 500, checkCondition: () => furnace.outputItem() !== null })
assert.strictEqual(furnace.outputItem(), furnace.slots[2])
assert.strictEqual(furnace.outputItem().type, cookedPorkchopId)
assert.strictEqual(furnace.outputItem().count, 1)
Expand Down
Loading