Skip to content

Pna 2699 panels illustrative - #470

Draft
elhb wants to merge 5 commits into
pna-2699from
pna-2699-panels-illustrative
Draft

elhb wants to merge 5 commits into
pna-2699from
pna-2699-panels-illustrative

Conversation

@elhb

@elhb elhb commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

just to illustrate how panels split into base addon etc would look like


Note

Medium Risk
Removes several combined panel files and changes which panel names resolve in config; workflows or configs still pointing at deleted immuno-156-* or prerelease panels would break until they compose base + addon + hashing panels instead.

Overview
This PR restructures Proxiome PNA panel CSVs from monolithic “155 + extras” bundles into composable pieces tagged with panel_type (base, addon, sample_hashing).

Base immuno panels (proxiome-v1/v2-immuno-155) now declare panel_type: base. The v2.0 base panel drops embedded hashing rows (B2M/CD298/CD98 barcodes) that move into dedicated hashing panel files.

Addon marker panels are new small CSVs for FLAG, FMC63 (v1 and v2), and G4S (v2), each panel_type: addon, replacing deleted combined panels such as proxiome-*-immuno-156-FLAG/FMC63/G4S and v2 prerelease “everything in one file” variants.

Sample hashing is split out as proxiome-v2-hashing-prerelease and proxiome-v2-hashing-v2.0 (panel_type: sample_hashing); the old proxiome-v2-immuno-155-prerelease monolith is removed.

Tests in test_config.py are updated for the new panel inventory and the removed proxiome-v2-immuno-155-v1.0 alias case.

Reviewed by Cursor Bugbot for commit 01a5aed. Bugbot is set up for automated code reviews on this repo. Configure here.

@elhb
elhb requested a review from Aratz September 21, 2026 08:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 01a5aed. Configure here.

# description: >-
# Panel for the Proxiome Immuno Kit with 155 markers + 3 control markers + 3*8 hashing antibodies
# version: 2.0.0
# panel_type: base

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashing stripped from existing panel version

High Severity

proxiome-v2-immuno-155-v2.0 keeps the same name and version 2.0.0 after the 24 hashing rows move to proxiome-v2-hashing-v2.0, and its description still says it includes 3*8 hashing antibodies. Existing --panel proxiome-v2-immuno-155-v2.0 runs therefore drop sample-hashing markers with no load error.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 01a5aed. Configure here.

@elhb
elhb marked this pull request as draft September 21, 2026 08:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant