Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 01a5aed. Configure here.
| # description: >- | ||
| # Panel for the Proxiome Immuno Kit with 155 markers + 3 control markers + 3*8 hashing antibodies | ||
| # version: 2.0.0 | ||
| # panel_type: base |
There was a problem hiding this comment.
Hashing stripped from existing panel version
High Severity
proxiome-v2-immuno-155-v2.0 keeps the same name and version 2.0.0 after the 24 hashing rows move to proxiome-v2-hashing-v2.0, and its description still says it includes 3*8 hashing antibodies. Existing --panel proxiome-v2-immuno-155-v2.0 runs therefore drop sample-hashing markers with no load error.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 01a5aed. Configure here.
elhb
marked this pull request as draft
September 21, 2026 08:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


just to illustrate how panels split into base addon etc would look like
Note
Medium Risk
Removes several combined panel files and changes which panel names resolve in config; workflows or configs still pointing at deleted
immuno-156-*or prerelease panels would break until they compose base + addon + hashing panels instead.Overview
This PR restructures Proxiome PNA panel CSVs from monolithic “155 + extras” bundles into composable pieces tagged with
panel_type(base,addon,sample_hashing).Base immuno panels (
proxiome-v1/v2-immuno-155) now declarepanel_type: base. The v2.0 base panel drops embedded hashing rows (B2M/CD298/CD98 barcodes) that move into dedicated hashing panel files.Addon marker panels are new small CSVs for FLAG, FMC63 (v1 and v2), and G4S (v2), each
panel_type: addon, replacing deleted combined panels such asproxiome-*-immuno-156-FLAG/FMC63/G4Sand v2 prerelease “everything in one file” variants.Sample hashing is split out as
proxiome-v2-hashing-prereleaseandproxiome-v2-hashing-v2.0(panel_type: sample_hashing); the oldproxiome-v2-immuno-155-prereleasemonolith is removed.Tests in
test_config.pyare updated for the new panel inventory and the removedproxiome-v2-immuno-155-v1.0alias case.Reviewed by Cursor Bugbot for commit 01a5aed. Bugbot is set up for automated code reviews on this repo. Configure here.